Merge pull request #82 from ZimM-LostPolygon/gpu-temperature

fix: improved GPU temperature reliability

Gpu/NvidiaGpuTemperatureProvider.cs

@@ -19,14 +19,12 @@ public class NvidiaGpuTemperatureProvider : IGpuTemperatureProvider {
         if (!IsValid)
             return null;
 
+        PhysicalGPU internalGpu = _internalGpu!;
         IThermalSensor? gpuSensor = 
-            GPUApi.GetThermalSettings(_internalGpu!.Handle).Sensors
+            GPUApi.GetThermalSettings(internalGpu.Handle).Sensors
             .FirstOrDefault(s => s.Target == ThermalSettingsTarget.GPU);
 
-        if (gpuSensor == null)
+        return gpuSensor?.CurrentTemperature;
-            return null;
-
-        return gpuSensor.CurrentTemperature;
     }
 
     public void Dispose() {

HardwareMonitor.cs

@@ -40,19 +40,28 @@ public class HardwareMonitor
         try
         {
             gpuTemp = GpuTemperatureProvider?.GetCurrentTemperature();
-        } catch (Exception ex)
+        } catch (Exception ex) {
-        {
+            gpuTemp = null;
             Logger.WriteLine("Failed reading GPU temp");
             Logger.WriteLine(ex.ToString());
         }
 
     }
 
+    public static void RecreateGpuTemperatureProviderWithRetry() {
+        RecreateGpuTemperatureProvider();
+
+        // Re-enabling the discrete GPU takes a bit of time,
+        // so a simple workaround is to refresh again after that happens
+        Task.Run(async () => {
+            await Task.Delay(TimeSpan.FromSeconds(3));
+            RecreateGpuTemperatureProvider();
+        });
+    }
+
     public static void RecreateGpuTemperatureProvider() {
         try {
-            if (GpuTemperatureProvider != null) {
+            GpuTemperatureProvider?.Dispose();
-                GpuTemperatureProvider.Dispose();
-            }
 
             // Detect valid GPU temperature provider.
             // We start with NVIDIA because there's always at least an integrated AMD GPU
@@ -73,7 +82,7 @@ public class HardwareMonitor
         
             GpuTemperatureProvider = null;
         } finally {
-            Debug.WriteLine($"GpuTemperatureProvider: {GpuTemperatureProvider?.GetType().Name}");
+            Logger.WriteLine($"GpuTemperatureProvider: {GpuTemperatureProvider?.GetType().Name}");
         }
     }
 }

Program.cs

@@ -8,6 +8,8 @@ public static class Logger
 {
     public static void WriteLine(string logMessage)
     {
+        Debug.WriteLine(logMessage);
+        
         var appPath = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData) + "\\GHelper";
         var logFile = appPath + "\\log.txt";
 
@@ -109,6 +111,7 @@ namespace GHelper
             settingsForm.SetStartupCheck(Startup.IsScheduled());
 
             SetAutoModes();
+            HardwareMonitor.RecreateGpuTemperatureProvider();
 
             // Subscribing for native power change events
 
@@ -205,15 +208,6 @@ namespace GHelper
             settingsForm.AutoGPUMode(isPlugged);
 
             settingsForm.SetMatrix(isPlugged);
-
-            HardwareMonitor.RecreateGpuTemperatureProvider();
-
-            // Re-enabling the discrete GPU takes a bit of time,
-            // so a simple workaround is to refresh again after that happens
-            Task.Run(async () => {
-                await Task.Delay(TimeSpan.FromSeconds(3));
-                HardwareMonitor.RecreateGpuTemperatureProvider();
-            });
         }
 
         private static void SystemEvents_PowerModeChanged(object sender, PowerModeChangedEventArgs e)

Settings.cs

@@ -935,6 +935,7 @@ namespace GHelper
                 Program.settingsForm.BeginInvoke(delegate
                 {
                     InitGPUMode();
+                    HardwareMonitor.RecreateGpuTemperatureProviderWithRetry();
                     Thread.Sleep(500);
                     AutoScreen(SystemInformation.PowerStatus.PowerLineStatus);
                 });
@@ -987,9 +988,12 @@ namespace GHelper
                 changed = true;
             }
 
-            if (changed)
+            if (changed) {
                 Program.config.setConfig("gpu_mode", GPUMode);
                 
+                HardwareMonitor.RecreateGpuTemperatureProviderWithRetry();
+            }
+
             if (restart)
             {
                 VisualiseGPUMode(GPUMode);