From 1478f80c1a3f83af14575750d1478e626f630807 Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Tue, 30 Jan 2024 15:24:49 +0100 Subject: [PATCH 1/7] Ally UI Fix --- app/AppConfig.cs | 2 +- app/Program.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/AppConfig.cs b/app/AppConfig.cs index 1456c10a..9c68b277 100644 --- a/app/AppConfig.cs +++ b/app/AppConfig.cs @@ -379,7 +379,7 @@ public static class AppConfig public static bool IsStrix() { - return ContainsModel("Strix") || ContainsModel("Scar"); + return ContainsModel("Strix") || ContainsModel("Scar") || ContainsModel("G703G"); } public static bool IsStrixLimitedRGB() diff --git a/app/Program.cs b/app/Program.cs index 4cee9ad4..d71bb0bd 100644 --- a/app/Program.cs +++ b/app/Program.cs @@ -280,7 +280,7 @@ namespace GHelper settingsForm.Left = Screen.FromControl(settingsForm).WorkingArea.Width - 10 - settingsForm.Width; if (AppConfig.IsAlly()) - settingsForm.Top = Screen.FromControl(settingsForm).Bounds.Height - 110 - settingsForm.Height; + settingsForm.Top = Math.Max(10, Screen.FromControl(settingsForm).Bounds.Height - 110 - settingsForm.Height); else settingsForm.Top = Screen.FromControl(settingsForm).WorkingArea.Height - 10 - settingsForm.Height; From 222cefcee237b062ff0891ed191fcb7285347d00 Mon Sep 17 00:00:00 2001 From: IceStormNG Date: Tue, 30 Jan 2024 16:58:54 +0100 Subject: [PATCH 2/7] LED brightness fix for TuF M3 Gen II (#2004) * Support for Strix Carry (P508) * Fixes polling rate, angle snapping and debounce for Gladius II Origin. * The Gen2 version of the TuF M3 uses 0-100 for brightness. --- app/Peripherals/Mouse/Models/TUFM3.cs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/Peripherals/Mouse/Models/TUFM3.cs b/app/Peripherals/Mouse/Models/TUFM3.cs index 57014589..633952bf 100644 --- a/app/Peripherals/Mouse/Models/TUFM3.cs +++ b/app/Peripherals/Mouse/Models/TUFM3.cs @@ -124,5 +124,11 @@ { return "TUF GAMING M3 (Gen II)"; } + + public override int MaxBrightness() + { + return 100; + } + } } From d440846cacc34322cc2cafd014e4abd15a771cba Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:13:16 +0100 Subject: [PATCH 3/7] Create peripherals_request.yml --- .../ISSUE_TEMPLATE/peripherals_request.yml | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/peripherals_request.yml diff --git a/.github/ISSUE_TEMPLATE/peripherals_request.yml b/.github/ISSUE_TEMPLATE/peripherals_request.yml new file mode 100644 index 00000000..d185c35d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/peripherals_request.yml @@ -0,0 +1,31 @@ +name: Mouse and other peripherals support request +description: Request support for a new device +body: + - type: input + id: device + attributes: + label: Mouse / peripheral model and version + placeholder: e.g. Asus TUF M4 Wireless + validations: + required: true + - type: textarea + id: description + attributes: + label: Armoury Crate Screenshots + description: Connect your mouse to Armoury Crate (maybe in a VM if you do not want to install it on your PC) and upload here screenshots of all the pages for your mouse for settings. + placeholder: Drag and drop screenshots here + validations: + required: true + - type: textarea + id: solution + attributes: + label: USB Details + description: Also, please use USB Tree View and send the text (especially the block with all the child devices) of the mouse. + placeholder: USB Tree View details + validations: + required: true + - type: textarea + id: additional + attributes: + label: Additional information. + placeholder: If applicable, add screenshots or other relevant information From 4ca5db4560621928cde86a916d18aaf5f45e7a68 Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Wed, 31 Jan 2024 17:16:48 +0100 Subject: [PATCH 4/7] Update peripherals_request.yml --- .github/ISSUE_TEMPLATE/peripherals_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/peripherals_request.yml b/.github/ISSUE_TEMPLATE/peripherals_request.yml index d185c35d..224cd89e 100644 --- a/.github/ISSUE_TEMPLATE/peripherals_request.yml +++ b/.github/ISSUE_TEMPLATE/peripherals_request.yml @@ -20,7 +20,7 @@ body: id: solution attributes: label: USB Details - description: Also, please use USB Tree View and send the text (especially the block with all the child devices) of the mouse. + description: Also, please use USB Tree View and send the text (especially the block with all the child devices) of the mouse. image placeholder: USB Tree View details validations: required: true From 00595b80f0b2259d80543ac7deb89ee380fae449 Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Wed, 31 Jan 2024 22:00:19 +0100 Subject: [PATCH 5/7] Update README.md --- docs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/README.md b/docs/README.md index e52094ae..4cfa084f 100644 --- a/docs/README.md +++ b/docs/README.md @@ -6,7 +6,7 @@ Small and lightweight Armoury Crate alternative for Asus laptops offering almost same functionality without extra bloat and unnecessary services. Works with all popular models, such as ROG Zephyrus G14, G15, G16, M16, Flow X13, Flow X16, Flow Z13, TUF Series, Strix / Scar Series, ProArt, VivoBook and many more! -# [:floppy_disk:Download](https://github.com/seerge/g-helper/releases/latest/download/GHelper.zip) +# [:floppy_disk:Download](https://github.com/seerge/g-helper/releases/download/v0.151/GHelper.zip) - [FAQ](https://github.com/seerge/g-helper/wiki/FAQ) - [Setup and Requirements](https://github.com/seerge/g-helper/wiki/Requirements) From d6386c397742cfb3919719c43ef22c7cff098212 Mon Sep 17 00:00:00 2001 From: IceStormNG Date: Thu, 1 Feb 2024 13:37:23 +0100 Subject: [PATCH 6/7] Support for ROG Strix Impact III (P518) (#2012) * Support for Strix Carry (P508) * Fixes polling rate, angle snapping and debounce for Gladius II Origin. * The Gen2 version of the TuF M3 uses 0-100 for brightness. * Adds support for ROG Strix Impact III (P518) --- .../Mouse/Models/StrixImpactIII.cs | 77 +++++++++++++++++++ app/Peripherals/PeripheralsProvider.cs | 1 + 2 files changed, 78 insertions(+) create mode 100644 app/Peripherals/Mouse/Models/StrixImpactIII.cs diff --git a/app/Peripherals/Mouse/Models/StrixImpactIII.cs b/app/Peripherals/Mouse/Models/StrixImpactIII.cs new file mode 100644 index 00000000..95df3de3 --- /dev/null +++ b/app/Peripherals/Mouse/Models/StrixImpactIII.cs @@ -0,0 +1,77 @@ +namespace GHelper.Peripherals.Mouse.Models +{ + //P518 + public class StrixImpactIII : AsusMouse + { + public StrixImpactIII() : base(0x0B05, 0x1A88, "mi_00", false) + { + } + + + public override int DPIProfileCount() + { + return 4; + } + + public override string GetDisplayName() + { + return "ROG Strix Impact III"; + } + + + public override PollingRate[] SupportedPollingrates() + { + return new PollingRate[] { + PollingRate.PR125Hz, + PollingRate.PR250Hz, + PollingRate.PR500Hz, + PollingRate.PR1000Hz + }; + } + + public override int ProfileCount() + { + return 3; + } + + public override int MaxDPI() + { + return 12_000; + } + + public override bool HasRGB() + { + return true; + } + + public override LightingZone[] SupportedLightingZones() + { + return new LightingZone[] { LightingZone.Logo, LightingZone.Scrollwheel }; + } + + public override bool IsLightingModeSupported(LightingMode lightingMode) + { + return lightingMode == LightingMode.Static + || lightingMode == LightingMode.Breathing + || lightingMode == LightingMode.ColorCycle + || lightingMode == LightingMode.React + || lightingMode == LightingMode.Off; + } + + + public override bool HasBattery() + { + return false; + } + + public override bool HasAngleSnapping() + { + return true; + } + + public override bool HasLowBatteryWarning() + { + return false; + } + } +} diff --git a/app/Peripherals/PeripheralsProvider.cs b/app/Peripherals/PeripheralsProvider.cs index 28b5c3af..bfef7896 100644 --- a/app/Peripherals/PeripheralsProvider.cs +++ b/app/Peripherals/PeripheralsProvider.cs @@ -214,6 +214,7 @@ namespace GHelper.Peripherals DetectMouse(new ChakramCore()); DetectMouse(new SpathaX()); DetectMouse(new StrixCarry()); + DetectMouse(new StrixImpactIII()); } public static void DetectMouse(AsusMouse am) From 993e1230328dc1e5e3049e3a7edf293f6a39d33e Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Thu, 1 Feb 2024 13:39:15 +0100 Subject: [PATCH 7/7] Update README.md --- docs/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/README.md b/docs/README.md index 4cfa084f..7f9647cb 100644 --- a/docs/README.md +++ b/docs/README.md @@ -95,6 +95,7 @@ Each BIOS mode is paired with matching Windows Power Mode. You can adjust this s - ROG Keris Wireless - ROG Strix Carry (P508) - ROG Strix III Gladius III Aimpoint Wireless (P711) +- ROG Strix Impact III (P518) - ROG Spatha - ROG Strix Impact II Wireless - TUF Gaming M4 Wireless (P306)