From 8db6939b3010368d94d5f09bdaef4247a13dc70c Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Fri, 21 Jul 2023 12:47:21 +0200 Subject: [PATCH 01/12] Update README.md --- docs/README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/README.md b/docs/README.md index 2d835492..b30dff1e 100644 --- a/docs/README.md +++ b/docs/README.md @@ -125,7 +125,11 @@ You can find them under ``%AppData%\GHelper`` folder. Please include them when p Open app, and uncheck and check again "run on startup". If it still doesn't help (by some reason), you can try to manually edit "GHelper" task in windows Task Scheduler, and add couple of seconds delay to start. #### How do I uninstall G-helper? -G-helper is a single exe, and it doesn't install anything in the system. To remove it - you can simply delete exe :) If you have applied any custom fan profiles or PPTs - before removing I would recommend selecting your favorite performance mode (for example balanced) and clicking "Factory defaults" under Fans + Power. +G-helper is a single exe, and it doesn't install anything in the system. To remove it - you can simply delete exe :) If you have applied any custom fan profiles or PPTs - before removing I would recommend selecting your +favorite performance mode (for example balanced) and clicking "Factory defaults" under Fans + Power. + +#### Can I undervolt my CPU ? +Currently you can undervolt AMD CPUs. If your model supports that - you will see undervolting slider under ``Fans+Power -> Advanced``. If you don't see slider there, it means your CPU doesn't support undervolting. Full list of models that suppor that [can be found here](https://github.com/seerge/g-helper/discussions/736) #### I have G14 2023 and my GPU refuses to disable/enable It seem to be an issue in older BIOS versions. As [users report](https://github.com/seerge/g-helper/issues/680) - latest BIOS 310 (installable via myasus / g-helper -> updates) resolves all issues :) So please update. From 2b26791dc05da55979d84cfc6e1ad814b25c2a3b Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Fri, 21 Jul 2023 12:59:51 +0200 Subject: [PATCH 02/12] New translations Strings.resx (Ukrainian) --- app/Properties/Strings.uk.resx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Properties/Strings.uk.resx b/app/Properties/Strings.uk.resx index 2fd0e1d0..44fea220 100644 --- a/app/Properties/Strings.uk.resx +++ b/app/Properties/Strings.uk.resx @@ -208,7 +208,7 @@ Ліміт заряду батареї - Battery Health + Стан батареї Оновлення BIOS та драйверів From b07f0a09fabd9ac1ae50dd9202a2057c5a9e12df Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Fri, 21 Jul 2023 12:59:52 +0200 Subject: [PATCH 03/12] New translations Strings.resx (Chinese Simplified) --- app/Properties/Strings.zh-CN.resx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Properties/Strings.zh-CN.resx b/app/Properties/Strings.zh-CN.resx index eb3e367a..8ba17090 100644 --- a/app/Properties/Strings.zh-CN.resx +++ b/app/Properties/Strings.zh-CN.resx @@ -208,7 +208,7 @@ 电池充电限制 - Battery Health + 电池健康 BIOS 和驱动程序更新 @@ -495,7 +495,7 @@ 切换 Aura 模式 - Auto Toggle Clamshell Mode + 自动启用外接显示器模式 切换 Fn 锁定 From 987ee1c0004b33c88bf9ea5711cb5f29750a40a7 Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Fri, 21 Jul 2023 14:46:05 +0200 Subject: [PATCH 04/12] New translations Strings.resx (Polish) --- app/Properties/Strings.pl.resx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Properties/Strings.pl.resx b/app/Properties/Strings.pl.resx index 7016f67a..3e4618fc 100644 --- a/app/Properties/Strings.pl.resx +++ b/app/Properties/Strings.pl.resx @@ -208,7 +208,7 @@ Limit ładowania baterii - Battery Health + Stan baterii Aktualizacje BIOS i sterowników @@ -294,7 +294,7 @@ Nadal chcesz kontynuować? Wentylatory i moc - Wentylator + Went Dostosuj From 25f842df9da8e799f5d85c55b0ce7a610c40eda2 Mon Sep 17 00:00:00 2001 From: IceStormNG Date: Fri, 21 Jul 2023 15:38:26 +0200 Subject: [PATCH 05/12] Only touch power settings if the user checks the box. But always disable the changes back to the defaults when the user unchecks it. --- app/Extra.cs | 11 ++++++++++- app/Helpers/ClamshellModeControl.cs | 24 +++++++++++++++++++----- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/app/Extra.cs b/app/Extra.cs index 44d8f35a..1036be28 100644 --- a/app/Extra.cs +++ b/app/Extra.cs @@ -475,7 +475,16 @@ namespace GHelper { AppConfig.Set("toggle_clamshell_mode", checkAutoToggleClamshellMode.Checked ? 1 : 0); ClamshellModeControl ctrl = new ClamshellModeControl(); - ctrl.ToggleLidAction(); + + if (checkAutoToggleClamshellMode.Checked) + { + ctrl.ToggleLidAction(); + } + else + { + ClamshellModeControl.DisableClamshellMode(); + } + } } } diff --git a/app/Helpers/ClamshellModeControl.cs b/app/Helpers/ClamshellModeControl.cs index b01e86bb..3115a44a 100644 --- a/app/Helpers/ClamshellModeControl.cs +++ b/app/Helpers/ClamshellModeControl.cs @@ -46,17 +46,31 @@ namespace GHelper.Helpers public void ToggleLidAction() { - if (IsInClamshellMode() && IsClamshellEnabled()) + if (!IsClamshellEnabled()) { - PowerNative.SetLidAction(0, true); - Logger.WriteLine("Engaging Clamshell Mode"); + return; + } + + if (IsInClamshellMode()) + { + EnableClamshellMode(); } else { - PowerNative.SetLidAction(1, true); - Logger.WriteLine("Disengaging Clamshell Mode"); + DisableClamshellMode(); } } + public static void DisableClamshellMode() + { + PowerNative.SetLidAction(1, true); + Logger.WriteLine("Disengaging Clamshell Mode"); + } + + public static void EnableClamshellMode() + { + PowerNative.SetLidAction(0, true); + Logger.WriteLine("Engaging Clamshell Mode"); + } public void UnregisterDisplayEvents() { From 5498bb9398012507ac8c290080536e4041dc2985 Mon Sep 17 00:00:00 2001 From: IceStormNG Date: Fri, 21 Jul 2023 15:39:23 +0200 Subject: [PATCH 06/12] This name makes more sense as it only checks for requirements --- app/Helpers/ClamshellModeControl.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Helpers/ClamshellModeControl.cs b/app/Helpers/ClamshellModeControl.cs index 3115a44a..b5a900ce 100644 --- a/app/Helpers/ClamshellModeControl.cs +++ b/app/Helpers/ClamshellModeControl.cs @@ -39,7 +39,7 @@ namespace GHelper.Helpers return SystemInformation.PowerStatus.PowerLineStatus == PowerLineStatus.Online; } - public bool IsInClamshellMode() + public bool IsInClamshellReady() { return IsExternalDisplayConnected() && IsChargerConnected(); } @@ -51,7 +51,7 @@ namespace GHelper.Helpers return; } - if (IsInClamshellMode()) + if (IsInClamshellReady()) { EnableClamshellMode(); } From fbc792cb1dac784126c4d30f98440970e7cfb793 Mon Sep 17 00:00:00 2001 From: IceStormNG Date: Fri, 21 Jul 2023 15:40:24 +0200 Subject: [PATCH 07/12] Only instanciate if needed. --- app/Extra.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Extra.cs b/app/Extra.cs index 1036be28..473df726 100644 --- a/app/Extra.cs +++ b/app/Extra.cs @@ -474,10 +474,10 @@ namespace GHelper private void checkAutoToggleClamshellMode_CheckedChanged(object sender, EventArgs e) { AppConfig.Set("toggle_clamshell_mode", checkAutoToggleClamshellMode.Checked ? 1 : 0); - ClamshellModeControl ctrl = new ClamshellModeControl(); if (checkAutoToggleClamshellMode.Checked) { + ClamshellModeControl ctrl = new ClamshellModeControl(); ctrl.ToggleLidAction(); } else From d99c3a83010f08075fafd4727538ba242c368020 Mon Sep 17 00:00:00 2001 From: IceStormNG Date: Fri, 21 Jul 2023 15:42:40 +0200 Subject: [PATCH 08/12] Assign handler via code so the settings assignment does not trigger the handler --- app/Extra.Designer.cs | 1 - app/Extra.cs | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Extra.Designer.cs b/app/Extra.Designer.cs index 0a4b1b02..4d73aeea 100644 --- a/app/Extra.Designer.cs +++ b/app/Extra.Designer.cs @@ -1031,7 +1031,6 @@ namespace GHelper checkAutoToggleClamshellMode.TabIndex = 58; checkAutoToggleClamshellMode.Text = "Auto Toggle Clamshell Mode"; checkAutoToggleClamshellMode.UseVisualStyleBackColor = true; - checkAutoToggleClamshellMode.CheckedChanged += checkAutoToggleClamshellMode_CheckedChanged; // // checkAutoApplyWindowsPowerMode // diff --git a/app/Extra.cs b/app/Extra.cs index 473df726..66831b3a 100644 --- a/app/Extra.cs +++ b/app/Extra.cs @@ -213,6 +213,7 @@ namespace GHelper checkAutoToggleClamshellMode.Checked = AppConfig.Is("toggle_clamshell_mode"); + checkAutoToggleClamshellMode.CheckedChanged += checkAutoToggleClamshellMode_CheckedChanged; checkTopmost.Checked = AppConfig.Is("topmost"); checkTopmost.CheckedChanged += CheckTopmost_CheckedChanged; ; @@ -471,7 +472,7 @@ namespace GHelper AppConfig.Set("auto_apply_power_plan", checkAutoApplyWindowsPowerMode.Checked ? 1 : 0); } - private void checkAutoToggleClamshellMode_CheckedChanged(object sender, EventArgs e) + private void checkAutoToggleClamshellMode_CheckedChanged(object? sender, EventArgs e) { AppConfig.Set("toggle_clamshell_mode", checkAutoToggleClamshellMode.Checked ? 1 : 0); From 3f8773037507a639e59929433c429f043ed25a81 Mon Sep 17 00:00:00 2001 From: IceStormNG Date: Fri, 21 Jul 2023 15:45:42 +0200 Subject: [PATCH 09/12] Fixed a typo --- app/Helpers/ClamshellModeControl.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Helpers/ClamshellModeControl.cs b/app/Helpers/ClamshellModeControl.cs index b5a900ce..d4fb59fc 100644 --- a/app/Helpers/ClamshellModeControl.cs +++ b/app/Helpers/ClamshellModeControl.cs @@ -39,7 +39,7 @@ namespace GHelper.Helpers return SystemInformation.PowerStatus.PowerLineStatus == PowerLineStatus.Online; } - public bool IsInClamshellReady() + public bool IsClamshellReady() { return IsExternalDisplayConnected() && IsChargerConnected(); } @@ -51,7 +51,7 @@ namespace GHelper.Helpers return; } - if (IsInClamshellReady()) + if (IsClamshellReady()) { EnableClamshellMode(); } From 4592d729d3507660fbc36648d32c66954f1de558 Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Fri, 21 Jul 2023 18:26:01 +0200 Subject: [PATCH 10/12] New translations Strings.resx (Italian) --- app/Properties/Strings.it.resx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Properties/Strings.it.resx b/app/Properties/Strings.it.resx index 59e67f07..13d8e149 100644 --- a/app/Properties/Strings.it.resx +++ b/app/Properties/Strings.it.resx @@ -208,7 +208,7 @@ Limite Ricarica Batteria - Battery Health + Salute Batteria Aggiornamenti Driver e BIOS @@ -232,7 +232,7 @@ Colore - CPU Boost + Boost CPU Personalizzato From f2f4df5693cc3cc953505230c56dbf4047805e0d Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Fri, 21 Jul 2023 20:47:51 +0200 Subject: [PATCH 11/12] New translations Strings.resx (Spanish) --- app/Properties/Strings.es.resx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Properties/Strings.es.resx b/app/Properties/Strings.es.resx index 31da09d5..429bbb62 100644 --- a/app/Properties/Strings.es.resx +++ b/app/Properties/Strings.es.resx @@ -402,7 +402,7 @@ Nuevas actualizaciones - No hay nuevas actualizaciones + No hay actualizaciones Abrir ventana G-Helper From 633c841d7f00236eb03a490da2a1ba186ff1b645 Mon Sep 17 00:00:00 2001 From: Serge <5920850+seerge@users.noreply.github.com> Date: Sat, 22 Jul 2023 01:48:49 +0200 Subject: [PATCH 12/12] New translations Strings.resx (Chinese Traditional) --- app/Properties/Strings.zh-TW.resx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Properties/Strings.zh-TW.resx b/app/Properties/Strings.zh-TW.resx index e312213b..624ddc43 100644 --- a/app/Properties/Strings.zh-TW.resx +++ b/app/Properties/Strings.zh-TW.resx @@ -208,7 +208,7 @@ 電池充電上限 - Battery Health + 電池健康度 BIOS與驅動程式更新 Updates