Merge branch 'main' of https://github.com/seerge/g-helper

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,31 +1,40 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-title: ''
-labels: ''
-assignees: ''
 
 ---
 
 **Describe the bug**
 A clear and concise description of what the bug is.
 
-**To Reproduce**
+**Clear scenario to Reproduce**
 Steps to reproduce the behavior:
 1. Go to '...'
 2. Click on '....'
 3. Scroll down to '....'
-4. See error
+4. Explanation of an error or a bug
 
 **Expected behavior**
 A clear and concise description of what you expected to happen.
 
-**Screenshots**
+**App Logs**
+Please include and attach log.txt from ``%AppData%\GHelper``
+
+**Screenshots or screencasts**
 If applicable, add screenshots to help explain your problem.
 
 **Desktop (please complete the following information):**
- - OS: [e.g. iOS]
+ - OS: [e.g. Windows 11]
  - Laptop model
- 
+
+**Asus software**
+- Armoury crate (or it's services installed)
+- MyASUS installed
+- Other Asus services running in background
+
 **Additional context**
 Add any other context about the problem here.
+
+## NOTE
+Bug reports without clear information or scenario to reproduce will be closed without answer. 
+Please respect time of the developer. Thanks.

app/ASUSWmi.cs

@@ -213,6 +213,11 @@ public class ASUSWmi
 
         int result;
 
+        for (int i = 8; i < curve.Length; i++)
+        {
+            curve[i] = Math.Max((byte)0, Math.Min((byte)99, curve[i])); // it seems to be a bug, when some old model's bios can go nuts if fan is set to 100% 
+        }
+
         switch (device)
         {
             case 1:

app/Aura.cs

@@ -137,7 +137,7 @@ namespace GHelper
 
         public static bool HasSecondColor()
         {
-            return mode == 1;
+            return (mode == 1 && !Program.config.ContainsModel("TUF"));
         }
 
         public static int Speed

app/GHelper.csproj

@@ -16,7 +16,7 @@
     <PlatformTarget>x64</PlatformTarget>
     <ProduceReferenceAssembly>False</ProduceReferenceAssembly>
     <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
-    <AssemblyVersion>0.44</AssemblyVersion>
+    <AssemblyVersion>0.45</AssemblyVersion>
   </PropertyGroup>
 
   <ItemGroup>

app/HardwareMonitor.cs

@@ -47,13 +47,14 @@ public static class HardwareMonitor
     public static void ReadSensors()
     {
         batteryDischarge = -1;
+        gpuTemp = -1;
 
         cpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.CPU_Fan));
         gpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.GPU_Fan));
         midFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.Mid_Fan));
 
         cpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_CPU);
-        gpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_GPU);
+
 
         if (cpuTemp < 0) try
         {
@@ -72,11 +73,15 @@ public static class HardwareMonitor
 
         }
         catch (Exception ex) {
-            gpuTemp = null;
+            gpuTemp = -1;
             Logger.WriteLine("Failed reading GPU temp");
             Logger.WriteLine(ex.ToString());
         }
 
+        if (gpuTemp < 0)
+            gpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_GPU);
+
+
         try
         {
             var cb = new PerformanceCounter("Power Meter", "Power", "Power Meter (0)", true);

app/Program.cs

@@ -56,6 +56,7 @@ namespace GHelper
 
             }
 
+            Logger.WriteLine("------------");
             Logger.WriteLine("App launched");
 
             Application.EnableVisualStyles();