Added Strix/Scar built in aura modes

app/ASUSWmi.cs

@@ -31,6 +31,10 @@ public class ASUSWmi
     public const uint DevsGPUFanCurve = 0x00110025;
     public const uint DevsMidFanCurve = 0x00110032;
 
+    public const int Temp_CPU = 0x00120094;
+    public const int Temp_GPU = 0x00120097;
+
+
     public const int PPT_TotalA0 = 0x001200A0;  // Total PPT on 2022 and CPU PPT on 2021
     public const int PPT_EDCA1 = 0x001200A1;  // CPU EDC
     public const int PPT_TDCA2 = 0x001200A2;  // CPU TDC
@@ -153,21 +157,31 @@ public class ASUSWmi
 
     }
 
-    public byte[] DeviceSet(uint DeviceID, int Status)
+    public int DeviceSet(uint DeviceID, int Status, string logName)
     {
         byte[] args = new byte[8];
         BitConverter.GetBytes((uint)DeviceID).CopyTo(args, 0);
         BitConverter.GetBytes((uint)Status).CopyTo(args, 4);
-        return CallMethod(DEVS, args);
+
+        byte[] status = CallMethod(DEVS, args);
+        int result = BitConverter.ToInt32(status, 0);
+
+        Logger.WriteLine(logName + " = " + Status + " : " + (result == 1 ? "OK" : result));
+        return result;
     }
 
 
-    public byte[] DeviceSet(uint DeviceID, byte[] Params)
+    public int DeviceSet(uint DeviceID, byte[] Params, string logName)
     {
         byte[] args = new byte[4 + Params.Length];
         BitConverter.GetBytes((uint)DeviceID).CopyTo(args, 0);
         Params.CopyTo(args, 4);
-        return CallMethod(DEVS, args);
+
+        byte[] status = CallMethod(DEVS, args);
+        int result = BitConverter.ToInt32(status, 0);
+
+        Logger.WriteLine(logName + " = " + BitConverter.ToString(Params) + " : " + (result == 1 ? "OK" : result));
+        return BitConverter.ToInt32(status, 0);
     }
 
 
@@ -176,7 +190,9 @@ public class ASUSWmi
         byte[] args = new byte[8];
         BitConverter.GetBytes((uint)DeviceID).CopyTo(args, 0);
         byte[] status = CallMethod(DSTS, args);
+        
         return BitConverter.ToInt32(status, 0) - 65536;
+
     }
 
     public byte[] DeviceGetBuffer(uint DeviceID, uint Status = 0)
@@ -184,35 +200,33 @@ public class ASUSWmi
         byte[] args = new byte[8];
         BitConverter.GetBytes((uint)DeviceID).CopyTo(args, 0);
         BitConverter.GetBytes((uint)Status).CopyTo(args, 4);
+        
         return CallMethod(DSTS, args);
     }
 
 
-    public void SetFanCurve(int device, byte[] curve)
+    public int SetFanCurve(int device, byte[] curve)
     {
 
-        if (curve.Length != 16) return;
-        if (curve.All(singleByte => singleByte == 0)) return;
+        if (curve.Length != 16) return -1;
+        if (curve.All(singleByte => singleByte == 0)) return -1;
 
-        string name;
+        int result;
 
         switch (device)
         {
             case 1:
-                DeviceSet(DevsGPUFanCurve, curve);
-                name = "GPU";
+                result = DeviceSet(DevsGPUFanCurve, curve, "FanGPU");
                 break;
             case 2:
-                DeviceSet(DevsMidFanCurve, curve);
-                name = "Mid";
+                result = DeviceSet(DevsMidFanCurve, curve, "FanMid");
                 break;
             default:
-                DeviceSet(DevsCPUFanCurve, curve);
-                name = "CPU";
+                result = DeviceSet(DevsCPUFanCurve, curve, "FanCPU");
                 break;
         }
 
-        Logger.WriteLine("Fans" + name + " " + BitConverter.ToString(curve));
+        return result;
     }
 
     public byte[] GetFanCurve(int device, int mode = 0)
@@ -250,7 +264,7 @@ public class ASUSWmi
         setting[4] = color.B;
         setting[5] = (byte)speed;
 
-        DeviceSet(TUF_KB, setting);
+        DeviceSet(TUF_KB, setting, "TUF RGB");
         //Debug.WriteLine(BitConverter.ToString(setting));
 
     }
@@ -270,7 +284,7 @@ public class ASUSWmi
 
         state = state | 0x01 << 8;
 
-        DeviceSet(TUF_KB_STATE, state);
+        DeviceSet(TUF_KB_STATE, state, "TUF_KB");
     }
 
     public void SubscribeToEvents(Action<object, EventArrivedEventArgs> EventHandler)

app/AnimeMatrix/AnimeMatrixDevice.cs

@@ -4,6 +4,8 @@ using Starlight.Communication;
 using System.Management;
 using System.Drawing.Drawing2D;
 using System.Text;
+using System.Globalization;
+using System;
 
 namespace Starlight.AnimeMatrix
 {
@@ -359,6 +361,15 @@ namespace Starlight.AnimeMatrix
         }
 
 
+        public void PresentClock()
+        {
+            int second = DateTime.Now.Second;
+
+            if (CultureInfo.CurrentCulture.DateTimeFormat.ShortTimePattern.Contains("H"))
+                PresentText(DateTime.Now.ToString("H" + ((second % 2 == 0)?":":" ") + "mm"));
+            else
+                PresentText(DateTime.Now.ToString("h" + ((second % 2 == 0) ? ":" : " ") + "mm"), DateTime.Now.ToString("tt"));
+        }
 
         public void PresentText(string text1, string text2 = "")
         {
@@ -390,7 +401,7 @@ namespace Starlight.AnimeMatrix
 
         }
 
-        public void GenerateFrame(Image image, InterpolationMode interpolation = InterpolationMode.HighQualityBicubic)
+        public void GenerateFrame(Image image, InterpolationMode interpolation = InterpolationMode.High)
         {
 
             int width = MaxColumns/2 * 6;

app/AppConfig.cs

@@ -108,6 +108,8 @@ public class AppConfig
 
         if (device == 1)
             name = "gpu";
+        else if (device == 2)
+            name = "mid";
         else
             name = "cpu";
 

app/Aura.cs

@@ -1,5 +1,8 @@
 using HidLibrary;
+using System.Data;
 using System.Diagnostics;
+using static System.Windows.Forms.VisualStyles.VisualStyleElement.TextBox;
+using System.Security.Policy;
 
 namespace GHelper
 {
@@ -71,9 +74,8 @@ namespace GHelper
                 { 2, "Fast" }
             };
         }
-        public static Dictionary<int, string> GetModes()
-        {
-            return new Dictionary<int, string>
+
+        static  Dictionary<int, string> _modes = new Dictionary<int, string>
             {
                 { 0, "Static" },
                 { 1, "Breathe" },
@@ -81,6 +83,43 @@ namespace GHelper
                 { 3, "Rainbow" },
                 { 10, "Strobe" },
             };
+
+        static Dictionary<int, string> _modesStrix = new Dictionary<int, string>
+            {
+                { 0, "Static" },
+                { 1, "Breathe" },
+                { 2, "Color Cycle" },
+                { 3, "Rainbow" },
+                { 4, "Star" },
+                { 5, "Rain" },
+                { 6, "Highlight" },
+                { 7, "Laser" },
+                { 8, "Ripple" },
+                { 10, "Strobe" },
+                { 11, "Comet" },
+                { 12, "Flash" },
+            };
+
+
+        public static Dictionary<int, string> GetModes()
+        {
+            if (Program.config.ContainsModel("TUF"))
+            {
+                _modes.Remove(3);
+            }
+
+            if (Program.config.ContainsModel("401"))
+            {
+                _modes.Remove(2);
+                _modes.Remove(3);
+            }
+
+            if (Program.config.ContainsModel("Strix") || Program.config.ContainsModel("Scar"))
+            {
+                return _modesStrix;
+            }
+
+            return _modes;
         }
 
 
@@ -148,7 +187,7 @@ namespace GHelper
         {
             HidDevice[] HidDeviceList = HidDevices.Enumerate(0x0b05, deviceIds).ToArray();
 
-            byte[] msg = { 0x5a, 0xba, 0xc5, 0xc4, (byte)brightness };
+            byte[] msg = { 0x5d, 0xba, 0xc5, 0xc4, (byte)brightness };
 
             foreach (HidDevice device in HidDeviceList)
                 if (device.IsConnected && device.Description.Contains("HID"))
@@ -184,7 +223,8 @@ namespace GHelper
                     device.CloseDevice();
                 }
 
-            Program.wmi.TUFKeyboardPower(awake, boot, sleep, shutdown);
+            if (Program.config.ContainsModel("TUF"))
+                Program.wmi.TUFKeyboardPower(awake, boot, sleep, shutdown);
 
         }
 
@@ -220,7 +260,8 @@ namespace GHelper
                     device.CloseDevice();
                 }
 
-            Program.wmi.TUFKeyboardRGB(Mode, Color1, _speed);
+            if (Program.config.ContainsModel("TUF"))
+                Program.wmi.TUFKeyboardRGB(Mode, Color1, _speed);
 
         }
     }

app/ControlHelper.cs

@@ -9,6 +9,7 @@ public static class ControlHelper
     static bool _invert = false;
     static bool _darkTheme = false;
 
+
     static float _scale = 1;
 
     static Color formBack;
@@ -39,7 +40,7 @@ public static class ControlHelper
             foreMain = SystemColors.ControlText;
             foreAccent = Color.LightGray;
             borderMain = Color.LightGray;
-            buttonMain = Color.FromArgb(255, 250, 250, 250);
+            buttonMain = Color.FromArgb(255, 230, 230, 230);
         }
 
         container.BackColor = formBack;
@@ -105,7 +106,8 @@ public static class ControlHelper
                 combo.BackColor = backMain;
                 combo.ForeColor = foreMain;
                 combo.BorderColor = backMain;
-                combo.ButtonColor = buttonMain;
+                combo.ButtonColor = backMain;
+                combo.ArrowColor = foreMain;
             }
 
             var gb = control as GroupBox;

app/CustomControls.cs

@@ -71,8 +71,8 @@ namespace CustomControls
         }
 
 
-        private Color buttonColor = Color.FromArgb(255,230, 230, 230);
-        [DefaultValue(typeof(Color), "230, 230, 230")]
+        private Color buttonColor = Color.FromArgb(255, 255, 255, 255);
+        [DefaultValue(typeof(Color), "255, 255, 255")]
         public Color ButtonColor
         {
             get { return buttonColor; }

app/Fans.cs

@@ -18,7 +18,7 @@ namespace GHelper
         {
             if (percentage == 0) return "OFF";
 
-            return (200 * Math.Round((float)(MinRPM + (MaxRPM - MinRPM) * percentage * 0.01) / 200)).ToString() + unit;
+            return (200 * Math.Round((float)(MinRPM*100 + (MaxRPM - MinRPM) * percentage) / 200)).ToString() + unit;
         }
 
         void SetChart(Chart chart, int device)
@@ -89,14 +89,8 @@ namespace GHelper
             InitializeComponent();
             InitTheme();
 
-            MinRPM = 1800;
-
-            if (Program.config.ContainsModel("401"))
-                MaxRPM = 7200;
-            else if (Program.config.ContainsModel("503"))
-                MaxRPM = 6800;
-            else
-                MaxRPM = 5800;
+            MinRPM = 18;
+            MaxRPM = HardwareMonitor.GetFanMax();
 
 
 
@@ -340,7 +334,7 @@ namespace GHelper
 
         }
 
-        void ApplyProfile(Series series, int device)
+        void SaveProfile(Series series, int device)
         {
             byte[] curve = new byte[16];
             int i = 0;
@@ -352,17 +346,19 @@ namespace GHelper
             }
 
             Program.config.setFanConfig(device, curve);
-            Program.wmi.SetFanCurve(device, curve);
+            //Program.wmi.SetFanCurve(device, curve);
 
         }
 
 
         private void ButtonApply_Click(object? sender, EventArgs e)
         {
-            ApplyProfile(seriesCPU, 0);
-            ApplyProfile(seriesGPU, 1);
+            SaveProfile(seriesCPU, 0);
+            SaveProfile(seriesGPU, 1);
             if (Program.config.getConfig("mid_fan") == 1)
-                ApplyProfile(seriesMid, 2);
+                SaveProfile(seriesMid, 2);
+
+            Program.settingsForm.AutoFans(true);
         }
 
         private void ButtonReset_Click(object? sender, EventArgs e)
@@ -379,7 +375,7 @@ namespace GHelper
             Program.config.setConfigPerf("auto_apply", 0);
             Program.config.setConfigPerf("auto_apply_power", 0);
 
-            Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, Program.config.getConfig("performance_mode"));
+            Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, Program.config.getConfig("performance_mode"), "PerfMode");
 
             ApplyLabel(false);
         }

app/GHelper.csproj

@@ -16,7 +16,7 @@
     <PlatformTarget>x64</PlatformTarget>
     <ProduceReferenceAssembly>False</ProduceReferenceAssembly>
     <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
-    <AssemblyVersion>0.42</AssemblyVersion>
+    <AssemblyVersion>0.44</AssemblyVersion>
   </PropertyGroup>
 
   <ItemGroup>

app/HardwareMonitor.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics;
+using GHelper;
 using GHelper.Gpu;
 
 public static class HardwareMonitor
@@ -9,12 +10,52 @@ public static class HardwareMonitor
     public static float? batteryDischarge = -1;
     public static int? gpuTemp = null;
 
+    public static string? cpuFan;
+    public static string? gpuFan;
+    public static string? midFan;
+
+    public static int GetFanMax()
+    {
+        int max = 58;
+        if (Program.config.ContainsModel("401")) max = 72;
+        else if (Program.config.ContainsModel("503")) max = 68;
+        return Math.Max(max, Program.config.getConfig("fan_max"));
+    }
+
+    public static void SetFanMax(int fan)
+    {
+        Program.config.setConfig("fan_max", fan);
+    }
+    private static string FormatFan(int fan)
+    {
+        // fix for old models 
+        if (fan < 0)
+        {
+            fan += 65536;
+            if (fan <= 0 || fan > 100) return null; //nothing reasonable
+        }
+
+        int fanMax = GetFanMax();
+        if (fan > fanMax) SetFanMax(fan);
+
+        if (Program.config.getConfig("fan_rpm") == 1)
+            return " Fan: " + (fan * 100).ToString() + "RPM";
+        else
+            return " Fan: " + Math.Min(Math.Round((float)fan/fanMax*100), 100).ToString() + "%"; // relatively to 6000 rpm
+    }
+
     public static void ReadSensors()
     {
-        cpuTemp = -1;
         batteryDischarge = -1;
 
-        try
+        cpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.CPU_Fan));
+        gpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.GPU_Fan));
+        midFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.Mid_Fan));
+
+        cpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_CPU);
+        gpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_GPU);
+
+        if (cpuTemp < 0) try
         {
             var ct = new PerformanceCounter("Thermal Zone Information", "Temperature", @"\_TZ.THRM", true);
             cpuTemp = ct.NextValue() - 273;
@@ -24,26 +65,29 @@ public static class HardwareMonitor
             Logger.WriteLine("Failed reading CPU temp");
         }
 
+        if (gpuTemp < 0)  try
+        {
+           if (GpuTemperatureProvider is null) RecreateGpuTemperatureProvider();
+           gpuTemp = GpuTemperatureProvider?.GetCurrentTemperature();
+
+        }
+        catch (Exception ex) {
+            gpuTemp = null;
+            Logger.WriteLine("Failed reading GPU temp");
+            Logger.WriteLine(ex.ToString());
+        }
+
         try
         {
             var cb = new PerformanceCounter("Power Meter", "Power", "Power Meter (0)", true);
             batteryDischarge = cb.NextValue() / 1000;
             cb.Dispose();
 
-        } catch
+        }
+        catch
         {
             Logger.WriteLine("Failed reading Battery discharge");
         }
-
-        try
-        {
-            gpuTemp = GpuTemperatureProvider?.GetCurrentTemperature();
-        } catch (Exception ex) {
-            gpuTemp = null;
-            Logger.WriteLine("Failed reading GPU temp");
-            Logger.WriteLine(ex.ToString());
-        }
-
     }
 
     public static void RecreateGpuTemperatureProviderWithDelay() {

app/NativeMethods.cs

@@ -632,6 +632,7 @@ public class NativeMethods
         {
             dm.dmDisplayFrequency = frequency;
             int iRet = NativeMethods.ChangeDisplaySettingsEx(laptopScreen, ref dm, IntPtr.Zero, DisplaySettingsFlags.CDS_UPDATEREGISTRY, IntPtr.Zero);
+            Logger.WriteLine("Screen = " + frequency.ToString() + "Hz : " + (iRet == 0 ? "OK" : iRet));
             return iRet;
         }
 

app/Program.cs

@@ -56,16 +56,14 @@ namespace GHelper
 
             }
 
+            Logger.WriteLine("App launched");
 
             Application.EnableVisualStyles();
 
-            SystemEvents.UserPreferenceChanged += new UserPreferenceChangedEventHandler(SystemEvents_UserPreferenceChanged);
-
             var ds = settingsForm.Handle;
 
             trayIcon.MouseClick += TrayIcon_MouseClick;
 
-
             wmi.SubscribeToEvents(WatcherEventArrived);
 
             settingsForm.InitGPUMode();
@@ -75,10 +73,10 @@ namespace GHelper
             settingsForm.SetStartupCheck(Startup.IsScheduled());
 
             SetAutoModes();
-            HardwareMonitor.RecreateGpuTemperatureProvider();
 
             // Subscribing for system power change events
             SystemEvents.PowerModeChanged += SystemEvents_PowerModeChanged;
+            SystemEvents.UserPreferenceChanged += SystemEvents_UserPreferenceChanged;
 
 
             if (Environment.CurrentDirectory.Trim('\\') == Application.StartupPath.Trim('\\'))
@@ -157,7 +155,7 @@ namespace GHelper
             }
             catch
             {
-                Logger.WriteLine("Failed to run " + fileName);
+                Logger.WriteLine("Failed to run  " + fileName);
             }
 
 

app/Settings.Designer.cs

@@ -163,7 +163,6 @@ namespace GHelper
             // comboMatrix
             // 
             comboMatrix.BorderColor = Color.White;
-            comboMatrix.ButtonColor = SystemColors.ControlLight;
             comboMatrix.Dock = DockStyle.Top;
             comboMatrix.Font = new Font("Segoe UI", 9F, FontStyle.Regular, GraphicsUnit.Point);
             comboMatrix.FormattingEnabled = true;
@@ -179,7 +178,6 @@ namespace GHelper
             // comboMatrixRunning
             // 
             comboMatrixRunning.BorderColor = Color.White;
-            comboMatrixRunning.ButtonColor = SystemColors.ControlLight;
             comboMatrixRunning.Dock = DockStyle.Top;
             comboMatrixRunning.Font = new Font("Segoe UI", 9F, FontStyle.Regular, GraphicsUnit.Point);
             comboMatrixRunning.FormattingEnabled = true;
@@ -890,7 +888,6 @@ namespace GHelper
             // comboKeyboard
             // 
             comboKeyboard.BorderColor = Color.White;
-            comboKeyboard.ButtonColor = SystemColors.ControlLight;
             comboKeyboard.Dock = DockStyle.Top;
             comboKeyboard.FlatStyle = FlatStyle.Flat;
             comboKeyboard.Font = new Font("Segoe UI", 9F, FontStyle.Regular, GraphicsUnit.Point);

app/Settings.cs

@@ -2,7 +2,6 @@
 using Starlight.AnimeMatrix;
 using System.Diagnostics;
 using System.Drawing.Imaging;
-using System.Globalization;
 using System.Reflection;
 using System.Text.Json;
 using System.Timers;
@@ -118,7 +117,7 @@ namespace GHelper
             sliderBattery.ValueChanged += SliderBattery_ValueChanged;
             Program.trayIcon.MouseMove += TrayIcon_MouseMove;
 
-            aTimer = new System.Timers.Timer(500);
+            aTimer = new System.Timers.Timer(1000);
             aTimer.Elapsed += OnTimedEvent;
 
             // Subscribing for monitor power on events
@@ -137,7 +136,7 @@ namespace GHelper
 
             Task.Run(async () =>
             {
-                await Task.Delay(TimeSpan.FromSeconds(5));
+                await Task.Delay(TimeSpan.FromSeconds(1));
                 CheckForUpdatesAsync();
             });
 
@@ -354,29 +353,7 @@ namespace GHelper
                     mat.PresentNextFrame();
                     break;
                 case 3:
-                    string format1, format2;
-                    if (CultureInfo.CurrentCulture.DateTimeFormat.ShortTimePattern.Contains("H"))
-                    {
-                        format1 = "H:mm";
-                        format2 = "";
-                    }
-                    else
-                    {
-                        format1 = "h:mm";
-                        format2 = "tt";
-                    }
-
-                    if (matrixTick > 0)
-                    {
-                        format1 = format1.Replace(":", " ");
-                        matrixTick = 0;
-                    }
-                    else
-                    {
-                        matrixTick++;
-                    }
-
-                    mat.PresentText(DateTime.Now.ToString(format1), DateTime.Now.ToString(format2));
+                    mat.PresentClock();
                     break;
             }
 
@@ -716,19 +693,18 @@ namespace GHelper
             if (frequency > 0)
             {
                 NativeMethods.SetRefreshRate(frequency);
-                Logger.WriteLine("Screen " + frequency.ToString() + "Hz");
             }
 
             if (overdrive >= 0)
             {
                 if (Program.config.getConfig("no_overdrive") == 1) overdrive = 0;
-                Program.wmi.DeviceSet(ASUSWmi.ScreenOverdrive, overdrive);
+                Program.wmi.DeviceSet(ASUSWmi.ScreenOverdrive, overdrive, "ScreenOverdrive");
 
             }
 
             if (miniled >= 0)
             {
-                Program.wmi.DeviceSet(ASUSWmi.ScreenMiniled, miniled);
+                Program.wmi.DeviceSet(ASUSWmi.ScreenMiniled, miniled, "Miniled");
                 Debug.WriteLine("Miniled " + miniled);
             }
 
@@ -746,7 +722,6 @@ namespace GHelper
             bool overdriveSetting = (Program.config.getConfig("no_overdrive") != 1);
 
             int overdrive = Program.wmi.DeviceGet(ASUSWmi.ScreenOverdrive);
-
             int miniled = Program.wmi.DeviceGet(ASUSWmi.ScreenMiniled);
 
             bool screenEnabled = (frequency >= 0);
@@ -828,26 +803,12 @@ namespace GHelper
         }
 
 
-        private static string FormatFan(int fan)
-        {
-            if (fan < 0) return null;
-
-            if (Program.config.getConfig("fan_rpm") == 1)
-                return " Fan: " + (fan * 100).ToString() + "RPM";
-            else
-                return " Fan: " + Math.Min(Math.Round(fan / 0.6), 100).ToString() + "%"; // relatively to 6000 rpm
-        }
-
         private static void RefreshSensors(bool force = false)
         {
 
             if (!force && Math.Abs(DateTimeOffset.Now.ToUnixTimeMilliseconds() - lastRefresh) < 2000) return;
             lastRefresh = DateTimeOffset.Now.ToUnixTimeMilliseconds();
 
-            string cpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.CPU_Fan));
-            string gpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.GPU_Fan));
-            string midFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.Mid_Fan));
-
             string cpuTemp = "";
             string gpuTemp = "";
             string battery = "";
@@ -867,12 +828,16 @@ namespace GHelper
 
             Program.settingsForm.BeginInvoke(delegate
             {
-                Program.settingsForm.labelCPUFan.Text = "CPU" + cpuTemp + cpuFan;
-                Program.settingsForm.labelGPUFan.Text = "GPU" + gpuTemp + gpuFan;
-                if (midFan is not null) Program.settingsForm.labelMidFan.Text = "Mid" + midFan;
+                Program.settingsForm.labelCPUFan.Text = "CPU" + cpuTemp + HardwareMonitor.cpuFan;
+                Program.settingsForm.labelGPUFan.Text = "GPU" + gpuTemp + HardwareMonitor.gpuFan;
+                if (HardwareMonitor.midFan is not null)
+                    Program.settingsForm.labelMidFan.Text = "Mid" + HardwareMonitor.midFan;
+
                 Program.settingsForm.labelBattery.Text = battery;
 
-                Program.trayIcon.Text = "CPU" + cpuTemp + cpuFan + "\n" + "GPU" + gpuTemp + gpuFan + ((battery.Length > 0) ? ("\n" + battery) : "");
+                Program.trayIcon.Text = "CPU" + cpuTemp + HardwareMonitor.cpuFan + "\n"
+                                        + "GPU" + gpuTemp + HardwareMonitor.gpuFan +
+                                        ((battery.Length > 0) ? ("\n" + battery) : "");
 
             });
         }
@@ -888,7 +853,7 @@ namespace GHelper
                 this.Top = Screen.FromControl(this).WorkingArea.Height - 10 - this.Height;
                 this.Activate();
 
-                aTimer.Interval = 300;
+                //aTimer.Interval = 300;
                 aTimer.Enabled = true;
 
                 //RefreshSensors();
@@ -911,37 +876,45 @@ namespace GHelper
             if (limit_cpu < ASUSWmi.MinCPU) return;
 
             if (Program.wmi.DeviceGet(ASUSWmi.PPT_TotalA0) >= 0)
-                Program.wmi.DeviceSet(ASUSWmi.PPT_TotalA0, limit_total);
+                Program.wmi.DeviceSet(ASUSWmi.PPT_TotalA0, limit_total, "PowerLimit A");
 
             if (Program.wmi.DeviceGet(ASUSWmi.PPT_CPUB0) >= 0)
-                Program.wmi.DeviceSet(ASUSWmi.PPT_CPUB0, limit_cpu);
+                Program.wmi.DeviceSet(ASUSWmi.PPT_CPUB0, limit_cpu, "PowerLimit B");
+
 
-            Logger.WriteLine("PowerLimits " + limit_total.ToString() + ", " + limit_cpu.ToString());
 
 
         }
 
 
-        public void AutoFansAndPower()
+        public void AutoFans(bool force = false)
         {
 
-            if (Program.config.getConfigPerf("auto_apply") == 1)
+            if (force || Program.config.getConfigPerf("auto_apply") == 1)
             {
-                Program.wmi.SetFanCurve(0, Program.config.getFanConfig(0));
-                Program.wmi.SetFanCurve(1, Program.config.getFanConfig(1));
+                int cpuResult = Program.wmi.SetFanCurve(0, Program.config.getFanConfig(0));
+                int gpuResult = Program.wmi.SetFanCurve(1, Program.config.getFanConfig(1));
 
                 if (Program.config.getConfig("mid_fan") == 1)
                     Program.wmi.SetFanCurve(2, Program.config.getFanConfig(2));
 
-                labelPerf.Text = "Performance Mode+";
-
+                if (cpuResult != 1 || gpuResult != 1) // something went wrong, resetting to default profile
+                {
+                    int mode = Program.config.getConfig("performance_mode");
+                    Logger.WriteLine("Bios rejected fan curve, resetting mode to " + mode);
+                    Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, mode, "PerformanceMode");
+                }
+                else
+                    labelPerf.Text = "Performance Mode+";
             }
             else
-            {
                 labelPerf.Text = "Performance Mode";
-            }
 
-            if (Program.config.getConfigPerf("auto_apply_power") == 1)
+        }
+
+        public void AutoPower(bool force = false)
+        {
+            if (force || Program.config.getConfigPerf("auto_apply_power") == 1)
             {
                 var timer = new System.Timers.Timer(1000);
                 timer.Elapsed += delegate
@@ -953,12 +926,9 @@ namespace GHelper
                 timer.Start();
             }
 
-            if (Program.config.getConfigPerf("auto_boost") != -1)
-            {
-                NativeMethods.SetCPUBoost(Program.config.getConfigPerf("auto_boost"));
-            }
         }
 
+
         public void SetPerformanceMode(int PerformanceMode = ASUSWmi.PerformanceBalanced, bool notify = false)
         {
 
@@ -988,8 +958,7 @@ namespace GHelper
             Program.config.setConfig("performance_" + (int)SystemInformation.PowerStatus.PowerLineStatus, PerformanceMode);
             Program.config.setConfig("performance_mode", PerformanceMode);
 
-            Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, PerformanceMode);
-            Logger.WriteLine("PerfMode " + perfName + " " + PerformanceMode);
+            Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, PerformanceMode, "PerformanceMode");
 
             if (notify && (oldMode != PerformanceMode))
             {
@@ -1003,7 +972,13 @@ namespace GHelper
                 }
             }
 
-            AutoFansAndPower();
+            AutoFans();
+            AutoPower();
+
+            if (Program.config.getConfigPerf("auto_boost") != -1)
+            {
+                NativeMethods.SetCPUBoost(Program.config.getConfigPerf("auto_boost"));
+            }
 
             NativeMethods.SetPowerScheme(PerformanceMode);
 
@@ -1035,9 +1010,11 @@ namespace GHelper
             if (Program.config.getConfig("keyboard_auto") != 1) return;
 
             if (SystemInformation.PowerStatus.PowerLineStatus == PowerLineStatus.Online)
-                Program.wmi.DeviceSet(ASUSWmi.UniversalControl, ASUSWmi.KB_Light_Up);
+                Aura.ApplyBrightness(3);
+            //Program.wmi.DeviceSet(ASUSWmi.UniversalControl, ASUSWmi.KB_Light_Up);
             else
-                Program.wmi.DeviceSet(ASUSWmi.UniversalControl, ASUSWmi.KB_Light_Down);
+                Aura.ApplyBrightness(0);
+            //Program.wmi.DeviceSet(ASUSWmi.UniversalControl, ASUSWmi.KB_Light_Down);
 
 
         }
@@ -1119,6 +1096,9 @@ namespace GHelper
             int eco = Program.wmi.DeviceGet(ASUSWmi.GPUEco);
             int mux = Program.wmi.DeviceGet(ASUSWmi.GPUMux);
 
+            //Logger.WriteLine("Eco flag : " + eco);
+            //Logger.WriteLine("Mux flag : " + mux);
+
             int GpuMode;
 
             if (mux == 0)
@@ -1169,12 +1149,12 @@ namespace GHelper
                         foreach (var process in Process.GetProcessesByName(kill)) process.Kill();
                 }
 
-                Program.wmi.DeviceSet(ASUSWmi.GPUEco, eco);
+                Program.wmi.DeviceSet(ASUSWmi.GPUEco, eco, "GPUEco");
+
                 Program.settingsForm.BeginInvoke(delegate
                 {
-                    InitGPUMode();
-                    HardwareMonitor.RecreateGpuTemperatureProviderWithDelay();
                     Thread.Sleep(500);
+                    InitGPUMode();
                     AutoScreen();
                 });
             });
@@ -1203,7 +1183,7 @@ namespace GHelper
                 DialogResult dialogResult = MessageBox.Show("Switching off Ultimate Mode requires restart", "Reboot now?", MessageBoxButtons.YesNo);
                 if (dialogResult == DialogResult.Yes)
                 {
-                    Program.wmi.DeviceSet(ASUSWmi.GPUMux, 1);
+                    Program.wmi.DeviceSet(ASUSWmi.GPUMux, 1, "GPUMux");
                     restart = true;
                     changed = true;
                 }
@@ -1213,7 +1193,7 @@ namespace GHelper
                 DialogResult dialogResult = MessageBox.Show("Ultimate Mode requires restart", "Reboot now?", MessageBoxButtons.YesNo);
                 if (dialogResult == DialogResult.Yes)
                 {
-                    Program.wmi.DeviceSet(ASUSWmi.GPUMux, 0);
+                    Program.wmi.DeviceSet(ASUSWmi.GPUMux, 0, "GPUMux");
                     restart = true;
                     changed = true;
                 }
@@ -1329,7 +1309,7 @@ namespace GHelper
             labelBatteryTitle.Text = "Battery Charge Limit: " + limit.ToString() + "%";
             sliderBattery.Value = limit;
 
-            Program.wmi.DeviceSet(ASUSWmi.BatteryLimit, limit);
+            Program.wmi.DeviceSet(ASUSWmi.BatteryLimit, limit, "BatteryLimit");
             Program.config.setConfig("charge_limit", limit);
 
         }

bloat.bat

@@ -0,0 +1,19 @@
+sc config  AsusAppService start= auto
+sc config  ASUSLinkNear start= auto
+sc config  ASUSLinkRemote start= auto
+sc config  ASUSSoftwareManager start= auto
+sc config  ASUSSwitch start= auto
+sc config  ASUSSystemAnalysis start= auto
+sc config  ASUSSystemDiagnosis start= auto
+sc config  ArmouryCrateControlInterface start= auto
+
+sc START  AsusAppService
+sc START  ASUSLinkNear
+sc START  ASUSLinkRemote
+sc START  ASUSSoftwareManager
+sc START  ASUSSwitch
+sc START  ASUSSystemAnalysis
+sc START  ASUSSystemDiagnosis
+sc START ArmouryCrateControlInterface
+
+set /p asd="Hit enter to finish"

docs/README.md

@@ -1,23 +1,27 @@
-# [G-Helper (GHelper)](https://github.com/seerge/g-helper)
+ 
+# [G-Helper](https://github.com/seerge/g-helper)
 
 [![Github all releases](https://img.shields.io/github/downloads/seerge/g-helper/total.svg)](https://GitHub.com/seerge/g-helper/releases/) [![GitHub release](https://img.shields.io/github/release/seerge/g-helper.svg)](https://GitHub.com/seerge/g-helper/releases/) [![GitHub stars](https://img.shields.io/github/stars/seerge/g-helper.svg?style=social&label=Star)](https://GitHub.com/seerge/g-helper/stargazers/)
 
-## Open source Armoury Crate alternative for Asus laptops such as ROG Zephyrus G14, G15, Flow X13, Flow X16, TUF and other models
+## Lightweight Armoury Crate alternative for Asus laptops
+### Control tool for ROG Zephyrus G14, G15, Flow X13, Flow X16, TUF, Strix, Scar and other models
 
 A small utility that allows you to do almost everything you could do with Armoury Crate but without extra bloat and unnecessary services.
 
 ### :gift: Main advantages 
 
 1. Seamless and automatic GPU switching (without asking you to close all apps, etc)
-2. All performance modes can be fully customized (with fan curves and PPTs)
+2. All performance modes can be fully customised (with fan curves and PPTs)
 3. Very lightweight and consumes almost no resources, doesn't install any services. Just a single exe to run
-4. Simple and clean UI with easy access to all settings
+4. Simple and clean native UI with easy access to all settings
 
 ### [:floppy_disk: Download latest release](https://github.com/seerge/g-helper/releases/latest/download/GHelper.zip)
 
 If you like this app, please [star :star: it on Github](https://github.com/seerge/g-helper) and spread a word about it!
 
-![Screenshot](https://raw.githubusercontent.com/seerge/g-helper/main/docs/screenshot.png)
+If you post about app - please include a link. Thanks.
+
+![Screenshot 2023-03-30 115149](https://user-images.githubusercontent.com/5920850/228799078-bc93148f-6580-4319-b9e6-fbde4d246cd2.png)
 
 ### :zap: Main features
 
@@ -34,7 +38,7 @@ If you like this app, please [star :star: it on Github](https://github.com/seerg
 11. Battery charge limit to preserve battery health
 12. Monitor CPU / GPU temperature, fan speeds and battery discharge rate
 
-### :apple: Automatic switching of modes when on battery or plugged in
+### :gear: Automatic switching of modes when on battery or plugged in
 - Performance modes (app remembers last mode used on battery or when plugged)
 - Optimized GPU mode - disables dGPU on battery and enables when plugged
 - Auto Screen refresh rate (60hz on battery, 120+ hz when plugged)
@@ -43,7 +47,9 @@ To keep auto switching and hotkeys working the app needs to stay in running in t
 
 ### :rocket: Performance Modes
 
-Modes are **same** as in Armory Crate (as they are stored in bios), including default fan curves
+Modes are **same** as in Armoury Crate (as they are stored in bios), including default fan curves
+
+![Screenshot 2023-03-29 122534](https://user-images.githubusercontent.com/5920850/228505581-4e7d087c-bd0a-4a48-b572-de2c01192830.png)
 
 1. Silent (minimal or no fans, 70W PPT total, up to 45W PPT to CPU) + Best power efficiency setting in windows
 2. Balanced (balanced fans, 100W PPT total, up to 45W PPT to CPU) + Balanced setting in windows
@@ -60,11 +66,11 @@ PPTs are shown for G14 2022, for other models PPTs will be different as they are
 
 ## :question: FAQ
 
-### How do I stop Armory Crate install popup appearing every time I press M4 / Rog key?
+### How do I stop the Armory Crate install popup appearing every time I press the M4 / Rog key?
 Go to BIOS (F2 on boot), open Advanced Settings and disable "Armory Control Interface". 
-If it still appears - delete or move somwhere following file ``C:\Windows\System32\ASUSACCI\ArmouryCrateKeyControl.exe``
+If it still appears - delete or move somewhere following file ``C:\Windows\System32\ASUSACCI\ArmouryCrateKeyControl.exe``
 
-### Why Ultimate GPU mode is not available on my laptop?
+### Why is Ultimate GPU mode not available on my laptop?
 Ultimate mode is supported (by hardware) only on G14 2022 (and possibly other models from 2022+)
 
 ### I can't set Eco mode (disable dGPU) on my G14 2020
@@ -80,11 +86,17 @@ It doesn't. Your bios does (same as in case with armoury). What G-helper can do
 Click on them
 
 ### I don't see a GPU temperature in G-helper
-Most probably either you are using Eco / Optimized mode and your dGPU is simply off, or your windows has put dGPU into sleep (to preserve power). In this situations G-helper won't be able to reach your GPU and get readings
+Most probably either you are using Eco / Optimized mode and your dGPU is simply off, or your windows has put the dGPU into sleep (to preserve power). In this situations G-helper won't be able to reach your GPU and get readings
+
+### It says, that app is already running
+Please check system tray for a (G) icon. By default windows is keen to hide all icons, so you may need to click ^ to see them all. I would advise to right click on Task Bar select Task Bar Settings -> Other System Tray icons -> Mark G-Helper to be always ON.
 
 ### App doesn't start / or crashes, what should I do ?
 Open "Event Viewer" from start menu, go to Windows Logs -> Application and check for recent Errors mentioning G-Helper. If you see one - please post a [new issue](https://github.com/seerge/g-helper/issues) with all details from this error.
 
+### Can I use MyASUS app along with G-Helper?
+Sure, you can! The only problem is that MyASUS may override battery charge limit that you set before. My advice in such case would be to set same limit (i.e. 80%) in both MyASUS and G-Helper.
+
 ### How do I uninstall G-helper?
 G-helper is a single exe, and it doesn't install anything in the system. To remove it - you can simply delete exe :) If you have applied any custom fan profiles or PPTs - before removing I would recommend selecting your favorite performance mode (for example balanced) and clicking "Factory defaults" under Fans + Power.
 
@@ -96,13 +108,15 @@ G-helper is a single exe, and it doesn't install anything in the system. To remo
 2. Unzip to a folder of your choice
 3. Run **GHelper.exe**
 
-### Dependencies
+### Dependencies & Requirements
 
-- App requires [.NET7](https://dotnet.microsoft.com/en-us/download) to be installed. Most probably you already have it. Otherwise you can [download it](https://dotnet.microsoft.com/en-us/download).
+- Microsoft [.NET7](https://dotnet.microsoft.com/en-us/download). Most probably you already have it. Otherwise you can [download it](https://dotnet.microsoft.com/en-us/download/dotnet/thank-you/sdk-7.0.202-windows-x64-installer) from the official website.
 
-- I recommend keeping "Asus Optimization Service" running, as it keeps basic laptop hotkeys such as screen or keyboard brightness adjustment working. If you have (or had) MyASUS app installed, that service is most probably still up and running even after MyASUS uninstalls. It's part of [Asus System Control Interface](https://www.asus.com/support/FAQ/1047338/). You can install it, and later disable / remove unnecessary services by running [this bat file](https://raw.githubusercontent.com/seerge/g-helper/main/debloat.bat) as admin.
+- [Asus System Control Interface](https://dlcdnets.asus.com/pub/ASUS/nb/Image/CustomComponent/ASUSSystemControlInterfaceV3/ASUSSystemControlInterfaceV3.exe). If you have or had MyASUS app installed this "driver" probably still in place (even after MyASUS uninstalls). Alternatively - you can download and install it, and later disable / remove unnecessary services by running [this bat file](https://raw.githubusercontent.com/seerge/g-helper/main/debloat.bat) as admin.
 
-- It's not recommended to use an app in combination with Armoury Crate, cause they adjust the same settings. You can [uninstall it using it's own uninstall tool](https://dlcdnets.asus.com/pub/ASUS/mb/14Utilities/Armoury_Crate_Uninstall_Tool.zip?model=armoury%20crate). Just in case, you can always install it back later.
+- I recommend keeping "Asus Optimization Service" running, as it keeps basic laptop hotkeys such as screen or keyboard brightness adjustment working.
+
+- It's not recommended to use an app in combination with Armoury Crate services, cause they adjust the same settings. You can [uninstall it using it's own uninstall tool](https://dlcdnets.asus.com/pub/ASUS/mb/14Utilities/Armoury_Crate_Uninstall_Tool.zip?model=armoury%20crate). Just in case, you can always install it back later.
 
 Note: Doesn't need administrator privileges to run!