Force GPU mode

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,31 +1,40 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-title: ''
-labels: ''
-assignees: ''
 
 ---
 
 **Describe the bug**
 A clear and concise description of what the bug is.
 
-**To Reproduce**
+**Clear scenario to Reproduce**
 Steps to reproduce the behavior:
 1. Go to '...'
 2. Click on '....'
 3. Scroll down to '....'
-4. See error
+4. Explanation of an error or a bug
 
 **Expected behavior**
 A clear and concise description of what you expected to happen.
 
-**Screenshots**
+**App Logs**
+Please include and attach log.txt from ``%AppData%\GHelper``
+
+**Screenshots or screencasts**
 If applicable, add screenshots to help explain your problem.
 
 **Desktop (please complete the following information):**
- - OS: [e.g. iOS]
+ - OS: [e.g. Windows 11]
  - Laptop model
- 
+
+**Asus software**
+- Armoury crate (or it's services installed)
+- MyASUS installed
+- Other Asus services running in background
+
 **Additional context**
 Add any other context about the problem here.
+
+## NOTE
+Bug reports without clear information or scenario to reproduce will be closed without answer. 
+Please respect time of the developer. Thanks.

app/ASUSWmi.cs

@@ -157,21 +157,31 @@ public class ASUSWmi
 
     }
 
-    public byte[] DeviceSet(uint DeviceID, int Status)
+    public int DeviceSet(uint DeviceID, int Status, string logName)
     {
         byte[] args = new byte[8];
         BitConverter.GetBytes((uint)DeviceID).CopyTo(args, 0);
         BitConverter.GetBytes((uint)Status).CopyTo(args, 4);
-        return CallMethod(DEVS, args);
+
+        byte[] status = CallMethod(DEVS, args);
+        int result = BitConverter.ToInt32(status, 0);
+
+        Logger.WriteLine(logName + " = " + Status + " : " + (result == 1 ? "OK" : result));
+        return result;
     }
 
 
-    public byte[] DeviceSet(uint DeviceID, byte[] Params)
+    public int DeviceSet(uint DeviceID, byte[] Params, string logName)
     {
         byte[] args = new byte[4 + Params.Length];
         BitConverter.GetBytes((uint)DeviceID).CopyTo(args, 0);
         Params.CopyTo(args, 4);
-        return CallMethod(DEVS, args);
+
+        byte[] status = CallMethod(DEVS, args);
+        int result = BitConverter.ToInt32(status, 0);
+
+        Logger.WriteLine(logName + " = " + BitConverter.ToString(Params) + " : " + (result == 1 ? "OK" : result));
+        return BitConverter.ToInt32(status, 0);
     }
 
 
@@ -180,7 +190,9 @@ public class ASUSWmi
         byte[] args = new byte[8];
         BitConverter.GetBytes((uint)DeviceID).CopyTo(args, 0);
         byte[] status = CallMethod(DSTS, args);
+        
         return BitConverter.ToInt32(status, 0) - 65536;
+
     }
 
     public byte[] DeviceGetBuffer(uint DeviceID, uint Status = 0)
@@ -188,35 +200,38 @@ public class ASUSWmi
         byte[] args = new byte[8];
         BitConverter.GetBytes((uint)DeviceID).CopyTo(args, 0);
         BitConverter.GetBytes((uint)Status).CopyTo(args, 4);
+        
         return CallMethod(DSTS, args);
     }
 
 
-    public void SetFanCurve(int device, byte[] curve)
+    public int SetFanCurve(int device, byte[] curve)
     {
 
-        if (curve.Length != 16) return;
-        if (curve.All(singleByte => singleByte == 0)) return;
+        if (curve.Length != 16) return -1;
+        if (curve.All(singleByte => singleByte == 0)) return -1;
 
-        string name;
+        int result;
+
+        for (int i = 8; i < curve.Length; i++)
+        {
+            curve[i] = Math.Max((byte)0, Math.Min((byte)99, curve[i])); // it seems to be a bug, when some old model's bios can go nuts if fan is set to 100% 
+        }
 
         switch (device)
         {
             case 1:
-                DeviceSet(DevsGPUFanCurve, curve);
-                name = "GPU";
+                result = DeviceSet(DevsGPUFanCurve, curve, "FanGPU");
                 break;
             case 2:
-                DeviceSet(DevsMidFanCurve, curve);
-                name = "Mid";
+                result = DeviceSet(DevsMidFanCurve, curve, "FanMid");
                 break;
             default:
-                DeviceSet(DevsCPUFanCurve, curve);
-                name = "CPU";
+                result = DeviceSet(DevsCPUFanCurve, curve, "FanCPU");
                 break;
         }
 
-        Logger.WriteLine("Fans" + name + " " + BitConverter.ToString(curve));
+        return result;
     }
 
     public byte[] GetFanCurve(int device, int mode = 0)
@@ -254,7 +269,7 @@ public class ASUSWmi
         setting[4] = color.B;
         setting[5] = (byte)speed;
 
-        DeviceSet(TUF_KB, setting);
+        DeviceSet(TUF_KB, setting, "TUF RGB");
         //Debug.WriteLine(BitConverter.ToString(setting));
 
     }
@@ -274,16 +289,22 @@ public class ASUSWmi
 
         state = state | 0x01 << 8;
 
-        DeviceSet(TUF_KB_STATE, state);
+        DeviceSet(TUF_KB_STATE, state, "TUF_KB");
     }
 
     public void SubscribeToEvents(Action<object, EventArrivedEventArgs> EventHandler)
     {
-        ManagementEventWatcher watcher = new ManagementEventWatcher();
-        watcher.EventArrived += new EventArrivedEventHandler(EventHandler);
-        watcher.Scope = new ManagementScope("root\\wmi");
-        watcher.Query = new WqlEventQuery("SELECT * FROM AsusAtkWmiEvent");
-        watcher.Start();
+        try
+        {
+            ManagementEventWatcher watcher = new ManagementEventWatcher();
+            watcher.EventArrived += new EventArrivedEventHandler(EventHandler);
+            watcher.Scope = new ManagementScope("root\\wmi");
+            watcher.Query = new WqlEventQuery("SELECT * FROM AsusAtkWmiEvent");
+            watcher.Start();
+        } catch
+        {
+            Logger.WriteLine("Can't connect to ASUS WMI events");
+        }
     }
 
 }

app/AnimeMatrix/AnimeMatrixDevice.cs

@@ -4,6 +4,8 @@ using Starlight.Communication;
 using System.Management;
 using System.Drawing.Drawing2D;
 using System.Text;
+using System.Globalization;
+using System;
 
 namespace Starlight.AnimeMatrix
 {
@@ -359,6 +361,15 @@ namespace Starlight.AnimeMatrix
         }
 
 
+        public void PresentClock()
+        {
+            int second = DateTime.Now.Second;
+
+            if (CultureInfo.CurrentCulture.DateTimeFormat.ShortTimePattern.Contains("H"))
+                PresentText(DateTime.Now.ToString("H" + ((second % 2 == 0)?":":" ") + "mm"));
+            else
+                PresentText(DateTime.Now.ToString("h" + ((second % 2 == 0) ? ":" : " ") + "mm"), DateTime.Now.ToString("tt"));
+        }
 
         public void PresentText(string text1, string text2 = "")
         {
@@ -390,7 +401,7 @@ namespace Starlight.AnimeMatrix
 
         }
 
-        public void GenerateFrame(Image image, InterpolationMode interpolation = InterpolationMode.HighQualityBicubic)
+        public void GenerateFrame(Image image, InterpolationMode interpolation = InterpolationMode.High)
         {
 
             int width = MaxColumns/2 * 6;

app/Aura.cs

@@ -1,5 +1,8 @@
 using HidLibrary;
+using System.Data;
 using System.Diagnostics;
+using static System.Windows.Forms.VisualStyles.VisualStyleElement.TextBox;
+using System.Security.Policy;
 
 namespace GHelper
 {
@@ -81,6 +84,23 @@ namespace GHelper
                 { 10, "Strobe" },
             };
 
+        static Dictionary<int, string> _modesStrix = new Dictionary<int, string>
+            {
+                { 0, "Static" },
+                { 1, "Breathe" },
+                { 2, "Color Cycle" },
+                { 3, "Rainbow" },
+                { 4, "Star" },
+                { 5, "Rain" },
+                { 6, "Highlight" },
+                { 7, "Laser" },
+                { 8, "Ripple" },
+                { 10, "Strobe" },
+                { 11, "Comet" },
+                { 12, "Flash" },
+            };
+
+
         public static Dictionary<int, string> GetModes()
         {
             if (Program.config.ContainsModel("TUF"))
@@ -94,6 +114,11 @@ namespace GHelper
                 _modes.Remove(3);
             }
 
+            if (Program.config.ContainsModel("Strix") || Program.config.ContainsModel("Scar"))
+            {
+                return _modesStrix;
+            }
+
             return _modes;
         }
 
@@ -112,7 +137,7 @@ namespace GHelper
 
         public static bool HasSecondColor()
         {
-            return mode == 1;
+            return (mode == 1 && !Program.config.ContainsModel("TUF"));
         }
 
         public static int Speed
@@ -198,7 +223,8 @@ namespace GHelper
                     device.CloseDevice();
                 }
 
-            Program.wmi.TUFKeyboardPower(awake, boot, sleep, shutdown);
+            if (Program.config.ContainsModel("TUF"))
+                Program.wmi.TUFKeyboardPower(awake, boot, sleep, shutdown);
 
         }
 
@@ -234,7 +260,8 @@ namespace GHelper
                     device.CloseDevice();
                 }
 
-            Program.wmi.TUFKeyboardRGB(Mode, Color1, _speed);
+            if (Program.config.ContainsModel("TUF"))
+                Program.wmi.TUFKeyboardRGB(Mode, Color1, _speed);
 
         }
     }

app/ControlHelper.cs

@@ -40,7 +40,7 @@ public static class ControlHelper
             foreMain = SystemColors.ControlText;
             foreAccent = Color.LightGray;
             borderMain = Color.LightGray;
-            buttonMain = Color.FromArgb(255, 250, 250, 250);
+            buttonMain = Color.FromArgb(255, 230, 230, 230);
         }
 
         container.BackColor = formBack;
@@ -106,7 +106,8 @@ public static class ControlHelper
                 combo.BackColor = backMain;
                 combo.ForeColor = foreMain;
                 combo.BorderColor = backMain;
-                combo.ButtonColor = buttonMain;
+                combo.ButtonColor = backMain;
+                combo.ArrowColor = foreMain;
             }
 
             var gb = control as GroupBox;

app/CustomControls.cs

@@ -71,8 +71,8 @@ namespace CustomControls
         }
 
 
-        private Color buttonColor = Color.FromArgb(255,230, 230, 230);
-        [DefaultValue(typeof(Color), "230, 230, 230")]
+        private Color buttonColor = Color.FromArgb(255, 255, 255, 255);
+        [DefaultValue(typeof(Color), "255, 255, 255")]
         public Color ButtonColor
         {
             get { return buttonColor; }

app/Fans.cs

@@ -47,7 +47,7 @@ namespace GHelper
 
             chart.ChartAreas[0].AxisY.LabelStyle.Font = new Font("Arial", 7F);
 
-            var foreAccent = Color.FromArgb(255, 100, 100, 100);
+            var foreAccent = Color.FromArgb(255, 180, 180, 180);
 
             chart.ChartAreas[0].AxisX.MajorGrid.LineColor = foreAccent;
             chart.ChartAreas[0].AxisY.MajorGrid.LineColor = foreAccent;
@@ -334,7 +334,7 @@ namespace GHelper
 
         }
 
-        void ApplyProfile(Series series, int device)
+        void SaveProfile(Series series, int device)
         {
             byte[] curve = new byte[16];
             int i = 0;
@@ -346,17 +346,19 @@ namespace GHelper
             }
 
             Program.config.setFanConfig(device, curve);
-            Program.wmi.SetFanCurve(device, curve);
+            //Program.wmi.SetFanCurve(device, curve);
 
         }
 
 
         private void ButtonApply_Click(object? sender, EventArgs e)
         {
-            ApplyProfile(seriesCPU, 0);
-            ApplyProfile(seriesGPU, 1);
+            SaveProfile(seriesCPU, 0);
+            SaveProfile(seriesGPU, 1);
             if (Program.config.getConfig("mid_fan") == 1)
-                ApplyProfile(seriesMid, 2);
+                SaveProfile(seriesMid, 2);
+
+            Program.settingsForm.AutoFans(true);
         }
 
         private void ButtonReset_Click(object? sender, EventArgs e)
@@ -373,7 +375,7 @@ namespace GHelper
             Program.config.setConfigPerf("auto_apply", 0);
             Program.config.setConfigPerf("auto_apply_power", 0);
 
-            Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, Program.config.getConfig("performance_mode"));
+            Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, Program.config.getConfig("performance_mode"), "PerfMode");
 
             ApplyLabel(false);
         }

app/GHelper.csproj

@@ -16,7 +16,7 @@
     <PlatformTarget>x64</PlatformTarget>
     <ProduceReferenceAssembly>False</ProduceReferenceAssembly>
     <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
-    <AssemblyVersion>0.43</AssemblyVersion>
+    <AssemblyVersion>0.46</AssemblyVersion>
   </PropertyGroup>
 
   <ItemGroup>
@@ -48,7 +48,7 @@
     <PackageReference Include="NvAPIWrapper.Net" Version="0.8.1.101" />
     <PackageReference Include="System.Management" Version="7.0.0" />
     <PackageReference Include="TaskScheduler" Version="2.10.1" />
-    <PackageReference Include="WinForms.DataVisualization" Version="1.7.0" />
+    <PackageReference Include="WinForms.DataVisualization" Version="1.8.0" />
   </ItemGroup>
 
   <ItemGroup>

app/HardwareMonitor.cs

@@ -19,7 +19,6 @@ public static class HardwareMonitor
         int max = 58;
         if (Program.config.ContainsModel("401")) max = 72;
         else if (Program.config.ContainsModel("503")) max = 68;
-
         return Math.Max(max, Program.config.getConfig("fan_max"));
     }
 
@@ -48,13 +47,14 @@ public static class HardwareMonitor
     public static void ReadSensors()
     {
         batteryDischarge = -1;
+        gpuTemp = -1;
 
         cpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.CPU_Fan));
         gpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.GPU_Fan));
         midFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.Mid_Fan));
 
         cpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_CPU);
-        gpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_GPU);
+
 
         if (cpuTemp < 0) try
         {
@@ -73,11 +73,15 @@ public static class HardwareMonitor
 
         }
         catch (Exception ex) {
-            gpuTemp = null;
+            gpuTemp = -1;
             Logger.WriteLine("Failed reading GPU temp");
             Logger.WriteLine(ex.ToString());
         }
 
+        if (gpuTemp is null || gpuTemp < 0)
+            gpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_GPU);
+
+
         try
         {
             var cb = new PerformanceCounter("Power Meter", "Power", "Power Meter (0)", true);

app/NativeMethods.cs

@@ -632,6 +632,7 @@ public class NativeMethods
         {
             dm.dmDisplayFrequency = frequency;
             int iRet = NativeMethods.ChangeDisplaySettingsEx(laptopScreen, ref dm, IntPtr.Zero, DisplaySettingsFlags.CDS_UPDATEREGISTRY, IntPtr.Zero);
+            Logger.WriteLine("Screen = " + frequency.ToString() + "Hz : " + (iRet == 0 ? "OK" : iRet));
             return iRet;
         }
 

app/Program.cs

@@ -56,6 +56,8 @@ namespace GHelper
 
             }
 
+            Logger.WriteLine("------------");
+            Logger.WriteLine("App launched");
 
             Application.EnableVisualStyles();
 
@@ -65,7 +67,6 @@ namespace GHelper
 
             wmi.SubscribeToEvents(WatcherEventArrived);
 
-            settingsForm.InitGPUMode();
             settingsForm.InitAura();
             settingsForm.InitMatrix();
 
@@ -77,6 +78,10 @@ namespace GHelper
             SystemEvents.PowerModeChanged += SystemEvents_PowerModeChanged;
             SystemEvents.UserPreferenceChanged += SystemEvents_UserPreferenceChanged;
 
+            // Subscribing for monitor power on events
+            var settingGuid = new NativeMethods.PowerSettingGuid();
+            unRegPowerNotify = NativeMethods.RegisterPowerSettingNotification(ds, settingGuid.ConsoleDisplayState, NativeMethods.DEVICE_NOTIFY_WINDOW_HANDLE);
+
 
             if (Environment.CurrentDirectory.Trim('\\') == Application.StartupPath.Trim('\\'))
             {
@@ -127,8 +132,14 @@ namespace GHelper
             settingsForm.AutoPerformance();
 
             bool switched = settingsForm.AutoGPUMode();
-            if (!switched) settingsForm.AutoScreen();
 
+            if (!switched)
+            {
+                settingsForm.InitGPUMode();
+                settingsForm.AutoScreen();
+            }
+
+            settingsForm.AutoKeyboard();
             settingsForm.SetMatrix();
         }
 
@@ -137,7 +148,6 @@ namespace GHelper
             if (SystemInformation.PowerStatus.PowerLineStatus == isPlugged) return;
 
             Logger.WriteLine("Windows - Power Mode Changed");
-            settingsForm.AutoKeyboard();
             SetAutoModes();
         }
 
@@ -154,7 +164,7 @@ namespace GHelper
             }
             catch
             {
-                Logger.WriteLine("Failed to run " + fileName);
+                Logger.WriteLine("Failed to run  " + fileName);
             }
 
 

app/Settings.Designer.cs

@@ -163,7 +163,6 @@ namespace GHelper
             // comboMatrix
             // 
             comboMatrix.BorderColor = Color.White;
-            comboMatrix.ButtonColor = SystemColors.ControlLight;
             comboMatrix.Dock = DockStyle.Top;
             comboMatrix.Font = new Font("Segoe UI", 9F, FontStyle.Regular, GraphicsUnit.Point);
             comboMatrix.FormattingEnabled = true;
@@ -179,7 +178,6 @@ namespace GHelper
             // comboMatrixRunning
             // 
             comboMatrixRunning.BorderColor = Color.White;
-            comboMatrixRunning.ButtonColor = SystemColors.ControlLight;
             comboMatrixRunning.Dock = DockStyle.Top;
             comboMatrixRunning.Font = new Font("Segoe UI", 9F, FontStyle.Regular, GraphicsUnit.Point);
             comboMatrixRunning.FormattingEnabled = true;
@@ -890,7 +888,6 @@ namespace GHelper
             // comboKeyboard
             // 
             comboKeyboard.BorderColor = Color.White;
-            comboKeyboard.ButtonColor = SystemColors.ControlLight;
             comboKeyboard.Dock = DockStyle.Top;
             comboKeyboard.FlatStyle = FlatStyle.Flat;
             comboKeyboard.Font = new Font("Segoe UI", 9F, FontStyle.Regular, GraphicsUnit.Point);

app/Settings.cs

@@ -2,7 +2,6 @@
 using Starlight.AnimeMatrix;
 using System.Diagnostics;
 using System.Drawing.Imaging;
-using System.Globalization;
 using System.Reflection;
 using System.Text.Json;
 using System.Timers;
@@ -121,10 +120,6 @@ namespace GHelper
             aTimer = new System.Timers.Timer(1000);
             aTimer.Elapsed += OnTimedEvent;
 
-            // Subscribing for monitor power on events
-            var settingGuid = new NativeMethods.PowerSettingGuid();
-            Program.unRegPowerNotify = NativeMethods.RegisterPowerSettingNotification(Handle, settingGuid.ConsoleDisplayState, NativeMethods.DEVICE_NOTIFY_WINDOW_HANDLE);
-
             SetVersionLabel("Version: " + Assembly.GetExecutingAssembly().GetName().Version);
 
             string model = Program.config.GetModel();
@@ -354,29 +349,7 @@ namespace GHelper
                     mat.PresentNextFrame();
                     break;
                 case 3:
-                    string format1, format2;
-                    if (CultureInfo.CurrentCulture.DateTimeFormat.ShortTimePattern.Contains("H"))
-                    {
-                        format1 = "H:mm";
-                        format2 = "";
-                    }
-                    else
-                    {
-                        format1 = "h:mm";
-                        format2 = "tt";
-                    }
-
-                    if (matrixTick > 0)
-                    {
-                        format1 = format1.Replace(":", " ");
-                        matrixTick = 0;
-                    }
-                    else
-                    {
-                        matrixTick++;
-                    }
-
-                    mat.PresentText(DateTime.Now.ToString(format1), DateTime.Now.ToString(format2));
+                    mat.PresentClock();
                     break;
             }
 
@@ -716,19 +689,18 @@ namespace GHelper
             if (frequency > 0)
             {
                 NativeMethods.SetRefreshRate(frequency);
-                Logger.WriteLine("Screen " + frequency.ToString() + "Hz");
             }
 
             if (overdrive >= 0)
             {
                 if (Program.config.getConfig("no_overdrive") == 1) overdrive = 0;
-                Program.wmi.DeviceSet(ASUSWmi.ScreenOverdrive, overdrive);
+                Program.wmi.DeviceSet(ASUSWmi.ScreenOverdrive, overdrive, "ScreenOverdrive");
 
             }
 
             if (miniled >= 0)
             {
-                Program.wmi.DeviceSet(ASUSWmi.ScreenMiniled, miniled);
+                Program.wmi.DeviceSet(ASUSWmi.ScreenMiniled, miniled, "Miniled");
                 Debug.WriteLine("Miniled " + miniled);
             }
 
@@ -746,7 +718,6 @@ namespace GHelper
             bool overdriveSetting = (Program.config.getConfig("no_overdrive") != 1);
 
             int overdrive = Program.wmi.DeviceGet(ASUSWmi.ScreenOverdrive);
-
             int miniled = Program.wmi.DeviceGet(ASUSWmi.ScreenMiniled);
 
             bool screenEnabled = (frequency >= 0);
@@ -846,7 +817,7 @@ namespace GHelper
             if (HardwareMonitor.batteryDischarge > 0)
                 battery = "Discharging: " + Math.Round((decimal)HardwareMonitor.batteryDischarge, 1).ToString() + "W";
 
-            if (HardwareMonitor.gpuTemp != null)
+            if (HardwareMonitor.gpuTemp > 0)
             {
                 gpuTemp = $": {HardwareMonitor.gpuTemp}°C - ";
             }
@@ -855,13 +826,13 @@ namespace GHelper
             {
                 Program.settingsForm.labelCPUFan.Text = "CPU" + cpuTemp + HardwareMonitor.cpuFan;
                 Program.settingsForm.labelGPUFan.Text = "GPU" + gpuTemp + HardwareMonitor.gpuFan;
-                if (HardwareMonitor.midFan is not null) 
+                if (HardwareMonitor.midFan is not null)
                     Program.settingsForm.labelMidFan.Text = "Mid" + HardwareMonitor.midFan;
-                
+
                 Program.settingsForm.labelBattery.Text = battery;
 
-                Program.trayIcon.Text = "CPU" + cpuTemp + HardwareMonitor.cpuFan + "\n" 
-                                        + "GPU" + gpuTemp + HardwareMonitor.gpuFan + 
+                Program.trayIcon.Text = "CPU" + cpuTemp + HardwareMonitor.cpuFan + "\n"
+                                        + "GPU" + gpuTemp + HardwareMonitor.gpuFan +
                                         ((battery.Length > 0) ? ("\n" + battery) : "");
 
             });
@@ -901,37 +872,45 @@ namespace GHelper
             if (limit_cpu < ASUSWmi.MinCPU) return;
 
             if (Program.wmi.DeviceGet(ASUSWmi.PPT_TotalA0) >= 0)
-                Program.wmi.DeviceSet(ASUSWmi.PPT_TotalA0, limit_total);
+                Program.wmi.DeviceSet(ASUSWmi.PPT_TotalA0, limit_total, "PowerLimit A");
 
             if (Program.wmi.DeviceGet(ASUSWmi.PPT_CPUB0) >= 0)
-                Program.wmi.DeviceSet(ASUSWmi.PPT_CPUB0, limit_cpu);
+                Program.wmi.DeviceSet(ASUSWmi.PPT_CPUB0, limit_cpu, "PowerLimit B");
+
 
-            Logger.WriteLine("PowerLimits " + limit_total.ToString() + ", " + limit_cpu.ToString());
 
 
         }
 
 
-        public void AutoFansAndPower()
+        public void AutoFans(bool force = false)
         {
 
-            if (Program.config.getConfigPerf("auto_apply") == 1)
+            if (force || Program.config.getConfigPerf("auto_apply") == 1)
             {
-                Program.wmi.SetFanCurve(0, Program.config.getFanConfig(0));
-                Program.wmi.SetFanCurve(1, Program.config.getFanConfig(1));
+                int cpuResult = Program.wmi.SetFanCurve(0, Program.config.getFanConfig(0));
+                int gpuResult = Program.wmi.SetFanCurve(1, Program.config.getFanConfig(1));
 
                 if (Program.config.getConfig("mid_fan") == 1)
                     Program.wmi.SetFanCurve(2, Program.config.getFanConfig(2));
 
-                labelPerf.Text = "Performance Mode+";
-
+                if (cpuResult != 1 || gpuResult != 1) // something went wrong, resetting to default profile
+                {
+                    int mode = Program.config.getConfig("performance_mode");
+                    Logger.WriteLine("Bios rejected fan curve, resetting mode to " + mode);
+                    Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, mode, "PerformanceMode");
+                }
+                else
+                    labelPerf.Text = "Performance Mode+";
             }
             else
-            {
                 labelPerf.Text = "Performance Mode";
-            }
 
-            if (Program.config.getConfigPerf("auto_apply_power") == 1)
+        }
+
+        public void AutoPower(bool force = false)
+        {
+            if (force || Program.config.getConfigPerf("auto_apply_power") == 1)
             {
                 var timer = new System.Timers.Timer(1000);
                 timer.Elapsed += delegate
@@ -943,12 +922,9 @@ namespace GHelper
                 timer.Start();
             }
 
-            if (Program.config.getConfigPerf("auto_boost") != -1)
-            {
-                NativeMethods.SetCPUBoost(Program.config.getConfigPerf("auto_boost"));
-            }
         }
 
+
         public void SetPerformanceMode(int PerformanceMode = ASUSWmi.PerformanceBalanced, bool notify = false)
         {
 
@@ -978,8 +954,7 @@ namespace GHelper
             Program.config.setConfig("performance_" + (int)SystemInformation.PowerStatus.PowerLineStatus, PerformanceMode);
             Program.config.setConfig("performance_mode", PerformanceMode);
 
-            Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, PerformanceMode);
-            Logger.WriteLine("PerfMode " + perfName + " " + PerformanceMode);
+            Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, PerformanceMode, "PerformanceMode");
 
             if (notify && (oldMode != PerformanceMode))
             {
@@ -993,7 +968,13 @@ namespace GHelper
                 }
             }
 
-            AutoFansAndPower();
+            AutoFans();
+            AutoPower();
+
+            if (Program.config.getConfigPerf("auto_boost") != -1)
+            {
+                NativeMethods.SetCPUBoost(Program.config.getConfigPerf("auto_boost"));
+            }
 
             NativeMethods.SetPowerScheme(PerformanceMode);
 
@@ -1064,7 +1045,11 @@ namespace GHelper
             var Plugged = SystemInformation.PowerStatus.PowerLineStatus;
 
             bool GpuAuto = Program.config.getConfig("gpu_auto") == 1;
-            if (!GpuAuto) return false;
+            bool ForceGPU = Program.config.ContainsModel("503");
+
+            int GpuMode = Program.config.getConfig("gpu_mode");
+
+            if (!GpuAuto && !ForceGPU) return false;
 
             int eco = Program.wmi.DeviceGet(ASUSWmi.GPUEco);
             int mux = Program.wmi.DeviceGet(ASUSWmi.GPUMux);
@@ -1073,16 +1058,18 @@ namespace GHelper
                 return false;
             else
             {
-                if (eco == 1 && Plugged == PowerLineStatus.Online)  // Eco going Standard on plugged
-                {
-                    SetEcoGPU(0);
-                    return true;
-                }
-                else if (eco == 0 && Plugged != PowerLineStatus.Online)  // Standard going Eco on plugged
-                {
-                    SetEcoGPU(1);
-                    return true;
-                }
+                if (eco == 1)
+                    if ((GpuAuto && Plugged == PowerLineStatus.Online) || (ForceGPU && GpuMode == ASUSWmi.GPUModeStandard))
+                    {
+                        SetEcoGPU(0);
+                        return true;
+                    }
+                if (eco == 0)
+                    if ((GpuAuto && Plugged != PowerLineStatus.Online) || (ForceGPU && GpuMode == ASUSWmi.GPUModeEco))
+                    {
+                        SetEcoGPU(1);
+                        return true;
+                    }
             }
 
             return false;
@@ -1111,8 +1098,8 @@ namespace GHelper
             int eco = Program.wmi.DeviceGet(ASUSWmi.GPUEco);
             int mux = Program.wmi.DeviceGet(ASUSWmi.GPUMux);
 
-            //Logger.WriteLine("Eco flag : " + eco);
-            //Logger.WriteLine("Mux flag : " + mux);
+            Logger.WriteLine("Eco flag : " + eco);
+            Logger.WriteLine("Mux flag : " + mux);
 
             int GpuMode;
 
@@ -1164,8 +1151,7 @@ namespace GHelper
                         foreach (var process in Process.GetProcessesByName(kill)) process.Kill();
                 }
 
-                Program.wmi.DeviceSet(ASUSWmi.GPUEco, eco);
-                Logger.WriteLine("Setting Eco mode: " + eco);
+                Program.wmi.DeviceSet(ASUSWmi.GPUEco, eco, "GPUEco");
 
                 Program.settingsForm.BeginInvoke(delegate
                 {
@@ -1199,7 +1185,7 @@ namespace GHelper
                 DialogResult dialogResult = MessageBox.Show("Switching off Ultimate Mode requires restart", "Reboot now?", MessageBoxButtons.YesNo);
                 if (dialogResult == DialogResult.Yes)
                 {
-                    Program.wmi.DeviceSet(ASUSWmi.GPUMux, 1);
+                    Program.wmi.DeviceSet(ASUSWmi.GPUMux, 1, "GPUMux");
                     restart = true;
                     changed = true;
                 }
@@ -1209,7 +1195,7 @@ namespace GHelper
                 DialogResult dialogResult = MessageBox.Show("Ultimate Mode requires restart", "Reboot now?", MessageBoxButtons.YesNo);
                 if (dialogResult == DialogResult.Yes)
                 {
-                    Program.wmi.DeviceSet(ASUSWmi.GPUMux, 0);
+                    Program.wmi.DeviceSet(ASUSWmi.GPUMux, 0, "GPUMux");
                     restart = true;
                     changed = true;
                 }
@@ -1325,7 +1311,7 @@ namespace GHelper
             labelBatteryTitle.Text = "Battery Charge Limit: " + limit.ToString() + "%";
             sliderBattery.Value = limit;
 
-            Program.wmi.DeviceSet(ASUSWmi.BatteryLimit, limit);
+            Program.wmi.DeviceSet(ASUSWmi.BatteryLimit, limit, "BatteryLimit");
             Program.config.setConfig("charge_limit", limit);
 
         }

app/Startup.cs

@@ -22,31 +22,43 @@ public class Startup
 
         var userId = WindowsIdentity.GetCurrent().Name;
 
-        TaskDefinition td = TaskService.Instance.NewTask();
-        td.RegistrationInfo.Description = "GHelper Auto Start";
-        td.Triggers.Add(new LogonTrigger { UserId = userId });
-        td.Actions.Add(strExeFilePath);
-
-        td.Settings.StopIfGoingOnBatteries = false;
-        td.Settings.DisallowStartIfOnBatteries = false;
-        td.Settings.ExecutionTimeLimit = TimeSpan.Zero;
-
-        Debug.WriteLine(strExeFilePath);
-        Debug.WriteLine(userId);
-
-        try
+        using (TaskDefinition td = TaskService.Instance.NewTask())
         {
-            TaskService.Instance.RootFolder.RegisterTaskDefinition(taskName, td);
-        } catch (Exception e)
-        {
-            MessageBox.Show(e.ToString(), "Scheduler Error", MessageBoxButtons.OK);
+            td.RegistrationInfo.Description = "G-Helper Auto Start";
+            td.Triggers.Add(new LogonTrigger { UserId = userId });
+            td.Actions.Add(strExeFilePath);
+
+            td.Settings.StopIfGoingOnBatteries = false;
+            td.Settings.DisallowStartIfOnBatteries = false;
+            td.Settings.ExecutionTimeLimit = TimeSpan.Zero;
+
+            Debug.WriteLine(strExeFilePath);
+            Debug.WriteLine(userId);
+
+            try
+            {
+                TaskService.Instance.RootFolder.RegisterTaskDefinition(taskName, td);
+            }
+            catch (Exception e)
+            {
+                MessageBox.Show("Can't create a start up task. Try running Task Scheduler by hand and manually deleting GHelper task if it exists there.", "Scheduler Error", MessageBoxButtons.OK);
+            }
         }
 
     }
 
     public static void UnSchedule()
     {
-        TaskService taskService = new TaskService();
-        taskService.RootFolder.DeleteTask(taskName);
+        using (TaskService taskService = new TaskService())
+        {
+            try
+            {
+                taskService.RootFolder.DeleteTask(taskName);
+            }
+            catch (Exception e)
+            {
+                MessageBox.Show("Can't remove task. Try running Task Scheduler by hand and manually deleting GHelper task if it exists there.", "Scheduler Error", MessageBoxButtons.OK);
+            }
+        }
     }
 }

bloat.bat

@@ -0,0 +1,19 @@
+sc config  AsusAppService start= auto
+sc config  ASUSLinkNear start= auto
+sc config  ASUSLinkRemote start= auto
+sc config  ASUSSoftwareManager start= auto
+sc config  ASUSSwitch start= auto
+sc config  ASUSSystemAnalysis start= auto
+sc config  ASUSSystemDiagnosis start= auto
+sc config  ArmouryCrateControlInterface start= auto
+
+sc START  AsusAppService
+sc START  ASUSLinkNear
+sc START  ASUSLinkRemote
+sc START  ASUSSoftwareManager
+sc START  ASUSSwitch
+sc START  ASUSSystemAnalysis
+sc START  ASUSSystemDiagnosis
+sc START ArmouryCrateControlInterface
+
+set /p asd="Hit enter to finish"

docs/README.md

@@ -2,7 +2,8 @@
 
 [![Github all releases](https://img.shields.io/github/downloads/seerge/g-helper/total.svg)](https://GitHub.com/seerge/g-helper/releases/) [![GitHub release](https://img.shields.io/github/release/seerge/g-helper.svg)](https://GitHub.com/seerge/g-helper/releases/) [![GitHub stars](https://img.shields.io/github/stars/seerge/g-helper.svg?style=social&label=Star)](https://GitHub.com/seerge/g-helper/stargazers/)
 
-## Open source Armoury Crate alternative for Asus laptops such as ROG Zephyrus G14, G15, Flow X13, Flow X16, TUF and other models
+## Lightweight Armoury Crate alternative for Asus laptops
+### Control tool for ROG Zephyrus G14, G15, Flow X13, Flow X16, TUF, Strix, Scar and other models
 
 A small utility that allows you to do almost everything you could do with Armoury Crate but without extra bloat and unnecessary services.
 
@@ -13,13 +14,15 @@ A small utility that allows you to do almost everything you could do with Armour
 3. Very lightweight and consumes almost no resources, doesn't install any services. Just a single exe to run
 4. Simple and clean native UI with easy access to all settings
 
+_Doesn't need administrator privileges to run!_
+
 ### [:floppy_disk: Download latest release](https://github.com/seerge/g-helper/releases/latest/download/GHelper.zip)
 
 If you like this app, please [star :star: it on Github](https://github.com/seerge/g-helper) and spread a word about it!
 
-If you post about app - please include a link. Thanks.
+If you post about the app - please include a link. Thanks.
 
-![Screenshot 2023-03-29 122524](https://user-images.githubusercontent.com/5920850/228505505-c3682509-a9e4-4cac-a5fd-e10d30c477cd.png)
+![Screenshot 2023-03-30 115149](https://user-images.githubusercontent.com/5920850/228799078-bc93148f-6580-4319-b9e6-fbde4d246cd2.png)
 
 ### :zap: Main features
 
@@ -28,7 +31,7 @@ If you post about app - please include a link. Thanks.
 3. Laptop screen refresh rate 60hz or 120hz (144hz, etc depending on the model) with display overdrive (OD)
 4. Default and custom fan profiles for every performance mode
 5. Power limits (PPT) for every performance mode
-6. CPU turbo boost mode
+6. CPU turbo boost setting for each mode
 7. Keyboard backlit animation and colors
 8. Anime matrix control thanks to [Starlight](https://github.com/vddCore/Starlight) + some tweaks from my side (including animated GIFs)
 9. FN+F5 cycles performance modes, FN+F4 cycles keyboard animation modes
@@ -36,16 +39,17 @@ If you post about app - please include a link. Thanks.
 11. Battery charge limit to preserve battery health
 12. Monitor CPU / GPU temperature, fan speeds and battery discharge rate
 
-### :apple: Automatic switching of modes when on battery or plugged in
+### :gear: Automatic switching when on battery or plugged in
 - Performance modes (app remembers last mode used on battery or when plugged)
 - Optimized GPU mode - disables dGPU on battery and enables when plugged
 - Auto Screen refresh rate (60hz on battery, 120+ hz when plugged)
+- Keyboard backlight can be turned off on battery
 
 To keep auto switching and hotkeys working the app needs to stay in running in the tray. It doesn't consume any resources. 
 
 ### :rocket: Performance Modes
 
-Modes are **same** as in Armory Crate (as they are stored in bios), including default fan curves
+Modes are **same** as in Armoury Crate (as they are stored in bios), including default fan curves
 
 ![Screenshot 2023-03-29 122534](https://user-images.githubusercontent.com/5920850/228505581-4e7d087c-bd0a-4a48-b572-de2c01192830.png)
 
@@ -64,18 +68,18 @@ PPTs are shown for G14 2022, for other models PPTs will be different as they are
 
 ## :question: FAQ
 
-### How do I stop Armory Crate install popup appearing every time I press M4 / Rog key?
+### How do I stop the Armory Crate install popup appearing every time I press the M4 / Rog key?
 Go to BIOS (F2 on boot), open Advanced Settings and disable "Armory Control Interface". 
-If it still appears - delete or move somwhere following file ``C:\Windows\System32\ASUSACCI\ArmouryCrateKeyControl.exe``
+If it still appears - delete or move somewhere following file ``C:\Windows\System32\ASUSACCI\ArmouryCrateKeyControl.exe``
 
-### Why Ultimate GPU mode is not available on my laptop?
+### Why is Ultimate GPU mode not available on my laptop?
 Ultimate mode is supported (by hardware) only on G14 2022 (and possibly other models from 2022+)
 
 ### I can't set Eco mode (disable dGPU) on my G14 2020
 Unfortunately 2020 model doesn't support that on hardware level
 
 ### Should I apply custom PPTs and fan profiles?
-You don't have to, it's purely optional. From my experience built in (in bios) performance modes work well. Limit your power or apply custom fan curves only if you have issues. As sooon as you click Apply in fan + power section bios will be considering fan profile as "custom"! (no matter if you modified it or not)
+You don't have to, it's purely optional. From my experience built in (in bios) performance modes work well. Limit your power or apply custom fan curves only if you have issues. As soon as you click Apply in the fan + power section bios will be considering the fan profile as "custom"! (no matter if you modified it or not)
 
 ### How does G-helper control my fan speeds?
 It doesn't. Your bios does (same as in case with armoury). What G-helper can do - is (optionally) set a custom fan profile to current performance mode consisting of 8 pairs of temperature + fan speed % via same endpoint armoury seem to use.
@@ -84,11 +88,17 @@ It doesn't. Your bios does (same as in case with armoury). What G-helper can do
 Click on them
 
 ### I don't see a GPU temperature in G-helper
-Most probably either you are using Eco / Optimized mode and your dGPU is simply off, or your windows has put dGPU into sleep (to preserve power). In this situations G-helper won't be able to reach your GPU and get readings
+Most probably either you are using Eco / Optimized mode and your dGPU is simply off, or your windows has put the dGPU into sleep (to preserve power). In this situations G-helper won't be able to reach your GPU and get readings
+
+### It says, that app is already running
+Please check system tray for a (G) icon. By default windows is keen to hide all icons, so you may need to click ^ to see them all. I would advise to right click on Task Bar select Task Bar Settings -> Other System Tray icons -> Mark G-Helper to be always ON.
 
 ### App doesn't start / or crashes, what should I do ?
 Open "Event Viewer" from start menu, go to Windows Logs -> Application and check for recent Errors mentioning G-Helper. If you see one - please post a [new issue](https://github.com/seerge/g-helper/issues) with all details from this error.
 
+### Can I use MyASUS app along with G-Helper?
+Sure, you can! The only problem is that MyASUS may override the battery charge limit that you set before. My advice in such a situation would be to set the same limit (i.e. 80%) in both MyASUS and G-Helper.
+
 ### How do I uninstall G-helper?
 G-helper is a single exe, and it doesn't install anything in the system. To remove it - you can simply delete exe :) If you have applied any custom fan profiles or PPTs - before removing I would recommend selecting your favorite performance mode (for example balanced) and clicking "Factory defaults" under Fans + Power.
 
@@ -100,15 +110,17 @@ G-helper is a single exe, and it doesn't install anything in the system. To remo
 2. Unzip to a folder of your choice
 3. Run **GHelper.exe**
 
-### Dependencies
+### Dependencies & Requirements
 
-- App requires [.NET7](https://dotnet.microsoft.com/en-us/download) to be installed. Most probably you already have it. Otherwise you can [download it](https://dotnet.microsoft.com/en-us/download).
+- Microsoft [.NET7](https://dotnet.microsoft.com/en-us/download). Most probably you already have it. Otherwise you can [download it](https://dotnet.microsoft.com/en-us/download/dotnet/thank-you/sdk-7.0.202-windows-x64-installer) from the official website.
 
-- I recommend keeping "Asus Optimization Service" running, as it keeps basic laptop hotkeys such as screen or keyboard brightness adjustment working. If you have (or had) MyASUS app installed, that service is most probably still up and running even after MyASUS uninstalls. It's part of [Asus System Control Interface](https://www.asus.com/support/FAQ/1047338/). You can install it, and later disable / remove unnecessary services by running [this bat file](https://raw.githubusercontent.com/seerge/g-helper/main/debloat.bat) as admin.
+- [Asus System Control Interface](https://dlcdnets.asus.com/pub/ASUS/nb/Image/CustomComponent/ASUSSystemControlInterfaceV3/ASUSSystemControlInterfaceV3.exe). If you have or had MyASUS app installed this "driver" probably still in place (even after MyASUS uninstalls). Alternatively - you can download and install it
 
-- It's not recommended to use an app in combination with Armoury Crate, cause they adjust the same settings. You can [uninstall it using it's own uninstall tool](https://dlcdnets.asus.com/pub/ASUS/mb/14Utilities/Armoury_Crate_Uninstall_Tool.zip?model=armoury%20crate). Just in case, you can always install it back later.
+- Optionally(!) you can disable / remove unnecessary services by running [this debloat bat file](https://raw.githubusercontent.com/seerge/g-helper/main/debloat.bat) as admin. To restore services - run [this bloat bat file](https://raw.githubusercontent.com/seerge/g-helper/main/bloat.bat) instead.
 
-Note: Doesn't need administrator privileges to run!
+- I recommend keeping "Asus Optimization Service" running, as it keeps basic laptop hotkeys such as screen or keyboard brightness adjustment working.
+
+- It's not recommended to use an app in combination with Armoury Crate services, because they adjust the same settings. You can [uninstall it using it's own uninstall tool](https://dlcdnets.asus.com/pub/ASUS/mb/14Utilities/Armoury_Crate_Uninstall_Tool.zip?model=armoury%20crate). Just in case, you can always install it back later.
 
 -------------------------------