Fans + power ui simplification

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,31 +1,40 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-title: ''
-labels: ''
-assignees: ''
 
 ---
 
 **Describe the bug**
 A clear and concise description of what the bug is.
 
-**To Reproduce**
+**Clear scenario to Reproduce**
 Steps to reproduce the behavior:
 1. Go to '...'
 2. Click on '....'
 3. Scroll down to '....'
-4. See error
+4. Explanation of an error or a bug
 
 **Expected behavior**
 A clear and concise description of what you expected to happen.
 
-**Screenshots**
+**App Logs**
+Please include and attach log.txt from ``%AppData%\GHelper``
+
+**Screenshots or screencasts**
 If applicable, add screenshots to help explain your problem.
 
 **Desktop (please complete the following information):**
- - OS: [e.g. iOS]
+ - OS: [e.g. Windows 11]
  - Laptop model
- 
+
+**Asus software**
+- Armoury crate (or it's services installed)
+- MyASUS installed
+- Other Asus services running in background
+
 **Additional context**
 Add any other context about the problem here.
+
+## NOTE
+Bug reports without clear information or scenario to reproduce will be closed without answer. 
+Please respect time of the developer. Thanks.

app/ASUSWmi.cs

@@ -213,6 +213,11 @@ public class ASUSWmi
 
         int result;
 
+        for (int i = 8; i < curve.Length; i++)
+        {
+            curve[i] = Math.Max((byte)0, Math.Min((byte)99, curve[i])); // it seems to be a bug, when some old model's bios can go nuts if fan is set to 100% 
+        }
+
         switch (device)
         {
             case 1:
@@ -289,11 +294,17 @@ public class ASUSWmi
 
     public void SubscribeToEvents(Action<object, EventArrivedEventArgs> EventHandler)
     {
-        ManagementEventWatcher watcher = new ManagementEventWatcher();
-        watcher.EventArrived += new EventArrivedEventHandler(EventHandler);
-        watcher.Scope = new ManagementScope("root\\wmi");
-        watcher.Query = new WqlEventQuery("SELECT * FROM AsusAtkWmiEvent");
-        watcher.Start();
+        try
+        {
+            ManagementEventWatcher watcher = new ManagementEventWatcher();
+            watcher.EventArrived += new EventArrivedEventHandler(EventHandler);
+            watcher.Scope = new ManagementScope("root\\wmi");
+            watcher.Query = new WqlEventQuery("SELECT * FROM AsusAtkWmiEvent");
+            watcher.Start();
+        } catch
+        {
+            Logger.WriteLine("Can't connect to ASUS WMI events");
+        }
     }
 
 }

app/Aura.cs

@@ -137,7 +137,7 @@ namespace GHelper
 
         public static bool HasSecondColor()
         {
-            return mode == 1;
+            return (mode == 1 && !Program.config.ContainsModel("TUF"));
         }
 
         public static int Speed

app/ControlHelper.cs

@@ -122,6 +122,12 @@ public static class ControlHelper
                 sl.borderColor = buttonMain;
             }
 
+            var chk = control as CheckBox;
+            if (chk != null)
+            {
+                chk.BackColor = buttonMain;
+            }
+
             var chart = control as Chart;
             if (chart != null)
             {

app/Fans.Designer.cs

@@ -31,12 +31,12 @@ namespace GHelper
         /// </summary>
         private void InitializeComponent()
         {
-            ChartArea chartArea1 = new ChartArea();
-            Title title1 = new Title();
-            ChartArea chartArea2 = new ChartArea();
-            Title title2 = new Title();
-            ChartArea chartArea3 = new ChartArea();
-            Title title3 = new Title();
+            ChartArea chartArea4 = new ChartArea();
+            Title title4 = new Title();
+            ChartArea chartArea5 = new ChartArea();
+            Title title5 = new Title();
+            ChartArea chartArea6 = new ChartArea();
+            Title title6 = new Title();
             panelFans = new Panel();
             labelTip = new Label();
             labelBoost = new Label();
@@ -47,14 +47,12 @@ namespace GHelper
             chartCPU = new Chart();
             chartMid = new Chart();
             labelFans = new Label();
-            checkAuto = new CheckBox();
+            checkApplyFans = new CheckBox();
             buttonReset = new RButton();
-            buttonApply = new RButton();
             panelPower = new Panel();
             pictureBox1 = new PictureBox();
             labelPowerLimits = new Label();
             checkApplyPower = new CheckBox();
-            buttonApplyPower = new RButton();
             panelCPU = new Panel();
             labelCPU = new Label();
             label2 = new Label();
@@ -63,7 +61,6 @@ namespace GHelper
             labelTotal = new Label();
             label1 = new Label();
             trackTotal = new TrackBar();
-            labelApplied = new Label();
             pictureFine = new PictureBox();
             labelInfo = new Label();
             panelFans.SuspendLayout();
@@ -89,9 +86,8 @@ namespace GHelper
             panelFans.Controls.Add(picturePerf);
             panelFans.Controls.Add(tableFanCharts);
             panelFans.Controls.Add(labelFans);
-            panelFans.Controls.Add(checkAuto);
+            panelFans.Controls.Add(checkApplyFans);
             panelFans.Controls.Add(buttonReset);
-            panelFans.Controls.Add(buttonApply);
             panelFans.Dock = DockStyle.Left;
             panelFans.Location = new Point(364, 0);
             panelFans.Margin = new Padding(0);
@@ -104,7 +100,7 @@ namespace GHelper
             // 
             labelTip.AutoSize = true;
             labelTip.BackColor = SystemColors.ControlLightLight;
-            labelTip.Location = new Point(245, 13);
+            labelTip.Location = new Point(271, 13);
             labelTip.Name = "labelTip";
             labelTip.Padding = new Padding(5);
             labelTip.Size = new Size(107, 42);
@@ -124,6 +120,7 @@ namespace GHelper
             // 
             comboBoost.Anchor = AnchorStyles.Top | AnchorStyles.Left | AnchorStyles.Right;
             comboBoost.BorderColor = Color.White;
+            comboBoost.ButtonColor = Color.FromArgb(255, 255, 255);
             comboBoost.DropDownStyle = ComboBoxStyle.DropDownList;
             comboBoost.FormattingEnabled = true;
             comboBoost.Items.AddRange(new object[] { "Disabled", "Enabled", "Aggressive", "Efficient Enabled", "Efficient Aggressive" });
@@ -164,8 +161,8 @@ namespace GHelper
             // 
             // chartGPU
             // 
-            chartArea1.Name = "ChartArea1";
-            chartGPU.ChartAreas.Add(chartArea1);
+            chartArea4.Name = "ChartArea1";
+            chartGPU.ChartAreas.Add(chartArea4);
             chartGPU.Dock = DockStyle.Fill;
             chartGPU.Location = new Point(2, 340);
             chartGPU.Margin = new Padding(2, 10, 2, 10);
@@ -173,13 +170,13 @@ namespace GHelper
             chartGPU.Size = new Size(760, 310);
             chartGPU.TabIndex = 17;
             chartGPU.Text = "chartGPU";
-            title1.Name = "Title1";
-            chartGPU.Titles.Add(title1);
+            title4.Name = "Title1";
+            chartGPU.Titles.Add(title4);
             // 
             // chartCPU
             // 
-            chartArea2.Name = "ChartArea1";
-            chartCPU.ChartAreas.Add(chartArea2);
+            chartArea5.Name = "ChartArea1";
+            chartCPU.ChartAreas.Add(chartArea5);
             chartCPU.Dock = DockStyle.Fill;
             chartCPU.Location = new Point(2, 10);
             chartCPU.Margin = new Padding(2, 10, 2, 10);
@@ -187,13 +184,13 @@ namespace GHelper
             chartCPU.Size = new Size(760, 310);
             chartCPU.TabIndex = 14;
             chartCPU.Text = "chartCPU";
-            title2.Name = "Title1";
-            chartCPU.Titles.Add(title2);
+            title5.Name = "Title1";
+            chartCPU.Titles.Add(title5);
             // 
             // chartMid
             // 
-            chartArea3.Name = "ChartArea3";
-            chartMid.ChartAreas.Add(chartArea3);
+            chartArea6.Name = "ChartArea3";
+            chartMid.ChartAreas.Add(chartArea6);
             chartMid.Dock = DockStyle.Fill;
             chartMid.Location = new Point(2, 670);
             chartMid.Margin = new Padding(2, 10, 2, 10);
@@ -201,8 +198,8 @@ namespace GHelper
             chartMid.Size = new Size(760, 312);
             chartMid.TabIndex = 14;
             chartMid.Text = "chartMid";
-            title3.Name = "Title3";
-            chartMid.Titles.Add(title3);
+            title6.Name = "Title3";
+            chartMid.Titles.Add(title6);
             chartMid.Visible = false;
             // 
             // labelFans
@@ -216,17 +213,19 @@ namespace GHelper
             labelFans.TabIndex = 28;
             labelFans.Text = "Fan Curves";
             // 
-            // checkAuto
+            // checkApplyFans
             // 
-            checkAuto.Anchor = AnchorStyles.Bottom | AnchorStyles.Right;
-            checkAuto.AutoSize = true;
-            checkAuto.Location = new Point(377, 1086);
-            checkAuto.Margin = new Padding(4, 2, 4, 2);
-            checkAuto.Name = "checkAuto";
-            checkAuto.Size = new Size(165, 36);
-            checkAuto.TabIndex = 17;
-            checkAuto.Text = "Auto Apply";
-            checkAuto.UseVisualStyleBackColor = true;
+            checkApplyFans.Anchor = AnchorStyles.Bottom | AnchorStyles.Right;
+            checkApplyFans.AutoSize = true;
+            checkApplyFans.BackColor = SystemColors.ControlLight;
+            checkApplyFans.Location = new Point(538, 1084);
+            checkApplyFans.Margin = new Padding(4, 2, 4, 2);
+            checkApplyFans.Name = "checkApplyFans";
+            checkApplyFans.Padding = new Padding(15, 5, 15, 5);
+            checkApplyFans.Size = new Size(250, 46);
+            checkApplyFans.TabIndex = 17;
+            checkApplyFans.Text = "Apply Fan Curve";
+            checkApplyFans.UseVisualStyleBackColor = false;
             // 
             // buttonReset
             // 
@@ -236,41 +235,22 @@ namespace GHelper
             buttonReset.BorderColor = Color.Transparent;
             buttonReset.BorderRadius = 2;
             buttonReset.FlatStyle = FlatStyle.Flat;
-            buttonReset.Location = new Point(30, 1081);
+            buttonReset.Location = new Point(30, 1084);
             buttonReset.Margin = new Padding(4, 2, 4, 2);
             buttonReset.Name = "buttonReset";
             buttonReset.Secondary = true;
-            buttonReset.Size = new Size(232, 44);
+            buttonReset.Size = new Size(232, 50);
             buttonReset.TabIndex = 15;
             buttonReset.Text = "Factory Defaults";
             buttonReset.UseVisualStyleBackColor = false;
             // 
-            // buttonApply
-            // 
-            buttonApply.Activated = false;
-            buttonApply.Anchor = AnchorStyles.Bottom | AnchorStyles.Right;
-            buttonApply.BackColor = Color.FromArgb(230, 230, 230);
-            buttonApply.BorderColor = Color.Transparent;
-            buttonApply.BorderRadius = 2;
-            buttonApply.FlatStyle = FlatStyle.Flat;
-            buttonApply.Location = new Point(542, 1081);
-            buttonApply.Margin = new Padding(4, 2, 4, 2);
-            buttonApply.Name = "buttonApply";
-            buttonApply.Secondary = true;
-            buttonApply.Size = new Size(248, 44);
-            buttonApply.TabIndex = 14;
-            buttonApply.Text = "Apply Custom Curve";
-            buttonApply.UseVisualStyleBackColor = false;
-            // 
             // panelPower
             // 
             panelPower.Controls.Add(pictureBox1);
             panelPower.Controls.Add(labelPowerLimits);
             panelPower.Controls.Add(checkApplyPower);
-            panelPower.Controls.Add(buttonApplyPower);
             panelPower.Controls.Add(panelCPU);
             panelPower.Controls.Add(panelTotal);
-            panelPower.Controls.Add(labelApplied);
             panelPower.Controls.Add(pictureFine);
             panelPower.Controls.Add(labelInfo);
             panelPower.Dock = DockStyle.Left;
@@ -308,37 +288,22 @@ namespace GHelper
             // 
             checkApplyPower.Anchor = AnchorStyles.Bottom | AnchorStyles.Left;
             checkApplyPower.AutoSize = true;
-            checkApplyPower.Location = new Point(27, 1039);
+            checkApplyPower.BackColor = SystemColors.ControlLight;
+            checkApplyPower.Location = new Point(20, 1086);
             checkApplyPower.Margin = new Padding(4, 2, 4, 2);
             checkApplyPower.Name = "checkApplyPower";
-            checkApplyPower.Size = new Size(165, 36);
+            checkApplyPower.Padding = new Padding(15, 5, 15, 5);
+            checkApplyPower.Size = new Size(277, 46);
             checkApplyPower.TabIndex = 25;
-            checkApplyPower.Text = "Auto Apply";
-            checkApplyPower.UseVisualStyleBackColor = true;
-            // 
-            // buttonApplyPower
-            // 
-            buttonApplyPower.Activated = false;
-            buttonApplyPower.Anchor = AnchorStyles.Bottom | AnchorStyles.Left | AnchorStyles.Right;
-            buttonApplyPower.BackColor = Color.FromArgb(230, 230, 230);
-            buttonApplyPower.BorderColor = Color.Transparent;
-            buttonApplyPower.BorderRadius = 2;
-            buttonApplyPower.FlatStyle = FlatStyle.Flat;
-            buttonApplyPower.Location = new Point(20, 1081);
-            buttonApplyPower.Margin = new Padding(4, 2, 4, 2);
-            buttonApplyPower.Name = "buttonApplyPower";
-            buttonApplyPower.Secondary = true;
-            buttonApplyPower.Size = new Size(324, 44);
-            buttonApplyPower.TabIndex = 24;
-            buttonApplyPower.Text = "Apply Power Limits";
-            buttonApplyPower.UseVisualStyleBackColor = false;
+            checkApplyPower.Text = "Apply Power Limits";
+            checkApplyPower.UseVisualStyleBackColor = false;
             // 
             // panelCPU
             // 
             panelCPU.Controls.Add(labelCPU);
             panelCPU.Controls.Add(label2);
             panelCPU.Controls.Add(trackCPU);
-            panelCPU.Location = new Point(184, 93);
+            panelCPU.Location = new Point(184, 72);
             panelCPU.Margin = new Padding(4);
             panelCPU.Name = "panelCPU";
             panelCPU.Size = new Size(160, 510);
@@ -384,7 +349,7 @@ namespace GHelper
             panelTotal.Controls.Add(labelTotal);
             panelTotal.Controls.Add(label1);
             panelTotal.Controls.Add(trackTotal);
-            panelTotal.Location = new Point(16, 93);
+            panelTotal.Location = new Point(16, 72);
             panelTotal.Margin = new Padding(4);
             panelTotal.Name = "panelTotal";
             panelTotal.Size = new Size(160, 512);
@@ -426,17 +391,6 @@ namespace GHelper
             trackTotal.TickStyle = TickStyle.TopLeft;
             trackTotal.Value = 125;
             // 
-            // labelApplied
-            // 
-            labelApplied.AutoSize = true;
-            labelApplied.ForeColor = Color.Tomato;
-            labelApplied.Location = new Point(56, 54);
-            labelApplied.Margin = new Padding(4, 0, 4, 0);
-            labelApplied.Name = "labelApplied";
-            labelApplied.Size = new Size(143, 32);
-            labelApplied.TabIndex = 21;
-            labelApplied.Text = "Not Applied";
-            // 
             // pictureFine
             // 
             pictureFine.Anchor = AnchorStyles.Top | AnchorStyles.Left | AnchorStyles.Right;
@@ -501,12 +455,10 @@ namespace GHelper
 
         #endregion
         private Panel panelFans;
-        private CheckBox checkAuto;
+        private CheckBox checkApplyFans;
         private RButton buttonReset;
-        private RButton buttonApply;
         private Panel panelPower;
         private CheckBox checkApplyPower;
-        private RButton buttonApplyPower;
         private Panel panelCPU;
         private Label labelCPU;
         private Label label2;
@@ -515,7 +467,6 @@ namespace GHelper
         private Label labelTotal;
         private Label label1;
         private TrackBar trackTotal;
-        private Label labelApplied;
         private PictureBox pictureFine;
         private Label labelInfo;
         private Label labelPowerLimits;

app/Fans.cs

@@ -18,7 +18,7 @@ namespace GHelper
         {
             if (percentage == 0) return "OFF";
 
-            return (200 * Math.Round((float)(MinRPM*100 + (MaxRPM - MinRPM) * percentage) / 200)).ToString() + unit;
+            return (200 * Math.Round((float)(MinRPM * 100 + (MaxRPM - MinRPM) * percentage) / 200)).ToString() + unit;
         }
 
         void SetChart(Chart chart, int device)
@@ -47,7 +47,7 @@ namespace GHelper
 
             chart.ChartAreas[0].AxisY.LabelStyle.Font = new Font("Arial", 7F);
 
-            var foreAccent = Color.FromArgb(255, 100, 100, 100);
+            var foreAccent = Color.FromArgb(255, 180, 180, 180);
 
             chart.ChartAreas[0].AxisX.MajorGrid.LineColor = foreAccent;
             chart.ChartAreas[0].AxisY.MajorGrid.LineColor = foreAccent;
@@ -117,7 +117,6 @@ namespace GHelper
             chartMid.MouseUp += ChartCPU_MouseUp;
 
             buttonReset.Click += ButtonReset_Click;
-            buttonApply.Click += ButtonApply_Click;
 
             trackTotal.Maximum = ASUSWmi.MaxTotal;
             trackTotal.Minimum = ASUSWmi.MinTotal;
@@ -125,12 +124,13 @@ namespace GHelper
             trackCPU.Maximum = ASUSWmi.MaxCPU;
             trackCPU.Minimum = ASUSWmi.MinCPU;
 
-            trackCPU.Scroll += TrackCPU_Scroll;
-            trackTotal.Scroll += TrackTotal_Scroll;
+            trackCPU.Scroll += TrackPower_Scroll;
+            trackTotal.Scroll += TrackPower_Scroll;
 
-            buttonApplyPower.Click += ButtonApplyPower_Click;
+            trackCPU.MouseUp += TrackPower_MouseUp;
+            trackTotal.MouseUp += TrackPower_MouseUp;
 
-            checkAuto.Click += CheckAuto_Click;
+            checkApplyFans.Click += CheckApplyFans_Click;
             checkApplyPower.Click += CheckApplyPower_Click;
 
             //labelInfo.MaximumSize = new Size(280, 0);
@@ -146,6 +146,11 @@ namespace GHelper
 
         }
 
+        private void TrackPower_MouseUp(object? sender, MouseEventArgs e)
+        {
+            Program.settingsForm.AutoPower();
+        }
+
 
         public void InitBoost()
         {
@@ -168,13 +173,38 @@ namespace GHelper
             if (sender is null) return;
             CheckBox chk = (CheckBox)sender;
             Program.config.setConfigPerf("auto_apply_power", chk.Checked ? 1 : 0);
+
+            if (chk.Checked)
+            {
+                Program.settingsForm.AutoPower();
+            }
+            else
+            {
+                Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, Program.config.getConfig("performance_mode"), "PerfMode");
+                Program.settingsForm.AutoFans();
+            }
+
         }
 
-        private void CheckAuto_Click(object? sender, EventArgs e)
+        private void CheckApplyFans_Click(object? sender, EventArgs e)
         {
             if (sender is null) return;
             CheckBox chk = (CheckBox)sender;
+
             Program.config.setConfigPerf("auto_apply", chk.Checked ? 1 : 0);
+
+            if (chk.Checked)
+            {
+                Program.settingsForm.AutoFans();
+            }
+            else
+            {
+                Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, Program.config.getConfig("performance_mode"), "PerfMode");
+                Program.settingsForm.AutoPower();
+            }
+
+
+
         }
 
         private void Fans_FormClosing(object? sender, FormClosingEventArgs e)
@@ -186,11 +216,6 @@ namespace GHelper
             }
         }
 
-        private void ButtonApplyPower_Click(object? sender, EventArgs e)
-        {
-            Program.settingsForm.SetPower();
-            ApplyLabel(true);
-        }
 
         public void InitPower(bool changed = false)
         {
@@ -215,13 +240,11 @@ namespace GHelper
             {
                 limit_total = trackTotal.Value;
                 limit_cpu = trackCPU.Value;
-                ApplyLabel(false);
             }
             else
             {
                 limit_total = Program.config.getConfigPerf("limit_total");
                 limit_cpu = Program.config.getConfigPerf("limit_cpu");
-                ApplyLabel(apply);
             }
 
             if (limit_total < 0) limit_total = ASUSWmi.DefaultTotal;
@@ -243,34 +266,16 @@ namespace GHelper
 
             Program.config.setConfigPerf("limit_total", limit_total);
             Program.config.setConfigPerf("limit_cpu", limit_cpu);
+
+
         }
 
 
-        private void TrackTotal_Scroll(object? sender, EventArgs e)
+        private void TrackPower_Scroll(object? sender, EventArgs e)
         {
             InitPower(true);
         }
 
-        private void TrackCPU_Scroll(object? sender, EventArgs e)
-        {
-            InitPower(true);
-        }
-
-
-        public void ApplyLabel(bool applied = false)
-        {
-            if (applied)
-            {
-                labelApplied.ForeColor = colorStandard;
-                labelApplied.Text = "Applied";
-            }
-            else
-            {
-                labelApplied.ForeColor = colorTurbo;
-                labelApplied.Text = "Not Applied";
-
-            }
-        }
 
         public void InitFans()
         {
@@ -299,7 +304,7 @@ namespace GHelper
 
             int auto_apply = Program.config.getConfigPerf("auto_apply");
 
-            checkAuto.Checked = (auto_apply == 1);
+            checkApplyFans.Checked = (auto_apply == 1);
 
         }
 
@@ -351,16 +356,6 @@ namespace GHelper
         }
 
 
-        private void ButtonApply_Click(object? sender, EventArgs e)
-        {
-            SaveProfile(seriesCPU, 0);
-            SaveProfile(seriesGPU, 1);
-            if (Program.config.getConfig("mid_fan") == 1)
-                SaveProfile(seriesMid, 2);
-
-            Program.settingsForm.AutoFans(true);
-        }
-
         private void ButtonReset_Click(object? sender, EventArgs e)
         {
 
@@ -369,21 +364,28 @@ namespace GHelper
             if (Program.config.getConfig("mid_fan") == 1)
                 LoadProfile(seriesMid, 2, 1);
 
-            checkAuto.Checked = false;
+            checkApplyFans.Checked = false;
             checkApplyPower.Checked = false;
 
             Program.config.setConfigPerf("auto_apply", 0);
             Program.config.setConfigPerf("auto_apply_power", 0);
 
             Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, Program.config.getConfig("performance_mode"), "PerfMode");
-
-            ApplyLabel(false);
         }
 
         private void ChartCPU_MouseUp(object? sender, MouseEventArgs e)
         {
             curPoint = null;
             labelTip.Visible = false;
+
+            SaveProfile(seriesCPU, 0);
+            SaveProfile(seriesGPU, 1);
+            if (Program.config.getConfig("mid_fan") == 1)
+                SaveProfile(seriesMid, 2);
+
+            Program.settingsForm.AutoFans();
+
+
         }
 
         private void ChartCPU_MouseMove(object? sender, MouseEventArgs e)

app/GHelper.csproj

@@ -16,7 +16,7 @@
     <PlatformTarget>x64</PlatformTarget>
     <ProduceReferenceAssembly>False</ProduceReferenceAssembly>
     <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
-    <AssemblyVersion>0.44</AssemblyVersion>
+    <AssemblyVersion>0.46</AssemblyVersion>
   </PropertyGroup>
 
   <ItemGroup>
@@ -48,7 +48,7 @@
     <PackageReference Include="NvAPIWrapper.Net" Version="0.8.1.101" />
     <PackageReference Include="System.Management" Version="7.0.0" />
     <PackageReference Include="TaskScheduler" Version="2.10.1" />
-    <PackageReference Include="WinForms.DataVisualization" Version="1.7.0" />
+    <PackageReference Include="WinForms.DataVisualization" Version="1.8.0" />
   </ItemGroup>
 
   <ItemGroup>

app/HardwareMonitor.cs

@@ -47,13 +47,14 @@ public static class HardwareMonitor
     public static void ReadSensors()
     {
         batteryDischarge = -1;
+        gpuTemp = -1;
 
         cpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.CPU_Fan));
         gpuFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.GPU_Fan));
         midFan = FormatFan(Program.wmi.DeviceGet(ASUSWmi.Mid_Fan));
 
         cpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_CPU);
-        gpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_GPU);
+
 
         if (cpuTemp < 0) try
         {
@@ -72,11 +73,15 @@ public static class HardwareMonitor
 
         }
         catch (Exception ex) {
-            gpuTemp = null;
+            gpuTemp = -1;
             Logger.WriteLine("Failed reading GPU temp");
             Logger.WriteLine(ex.ToString());
         }
 
+        if (gpuTemp is null || gpuTemp < 0)
+            gpuTemp = Program.wmi.DeviceGet(ASUSWmi.Temp_GPU);
+
+
         try
         {
             var cb = new PerformanceCounter("Power Meter", "Power", "Power Meter (0)", true);

app/Program.cs

@@ -56,6 +56,7 @@ namespace GHelper
 
             }
 
+            Logger.WriteLine("------------");
             Logger.WriteLine("App launched");
 
             Application.EnableVisualStyles();
@@ -66,7 +67,6 @@ namespace GHelper
 
             wmi.SubscribeToEvents(WatcherEventArrived);
 
-            settingsForm.InitGPUMode();
             settingsForm.InitAura();
             settingsForm.InitMatrix();
 
@@ -78,6 +78,10 @@ namespace GHelper
             SystemEvents.PowerModeChanged += SystemEvents_PowerModeChanged;
             SystemEvents.UserPreferenceChanged += SystemEvents_UserPreferenceChanged;
 
+            // Subscribing for monitor power on events
+            var settingGuid = new NativeMethods.PowerSettingGuid();
+            unRegPowerNotify = NativeMethods.RegisterPowerSettingNotification(ds, settingGuid.ConsoleDisplayState, NativeMethods.DEVICE_NOTIFY_WINDOW_HANDLE);
+
 
             if (Environment.CurrentDirectory.Trim('\\') == Application.StartupPath.Trim('\\'))
             {
@@ -128,8 +132,14 @@ namespace GHelper
             settingsForm.AutoPerformance();
 
             bool switched = settingsForm.AutoGPUMode();
-            if (!switched) settingsForm.AutoScreen();
 
+            if (!switched)
+            {
+                settingsForm.InitGPUMode();
+                settingsForm.AutoScreen();
+            }
+
+            settingsForm.AutoKeyboard();
             settingsForm.SetMatrix();
         }
 
@@ -138,7 +148,6 @@ namespace GHelper
             if (SystemInformation.PowerStatus.PowerLineStatus == isPlugged) return;
 
             Logger.WriteLine("Windows - Power Mode Changed");
-            settingsForm.AutoKeyboard();
             SetAutoModes();
         }
 

app/Settings.cs

@@ -120,10 +120,6 @@ namespace GHelper
             aTimer = new System.Timers.Timer(1000);
             aTimer.Elapsed += OnTimedEvent;
 
-            // Subscribing for monitor power on events
-            var settingGuid = new NativeMethods.PowerSettingGuid();
-            Program.unRegPowerNotify = NativeMethods.RegisterPowerSettingNotification(Handle, settingGuid.ConsoleDisplayState, NativeMethods.DEVICE_NOTIFY_WINDOW_HANDLE);
-
             SetVersionLabel("Version: " + Assembly.GetExecutingAssembly().GetName().Version);
 
             string model = Program.config.GetModel();
@@ -821,7 +817,7 @@ namespace GHelper
             if (HardwareMonitor.batteryDischarge > 0)
                 battery = "Discharging: " + Math.Round((decimal)HardwareMonitor.batteryDischarge, 1).ToString() + "W";
 
-            if (HardwareMonitor.gpuTemp != null)
+            if (HardwareMonitor.gpuTemp > 0)
             {
                 gpuTemp = $": {HardwareMonitor.gpuTemp}°C - ";
             }
@@ -881,16 +877,13 @@ namespace GHelper
             if (Program.wmi.DeviceGet(ASUSWmi.PPT_CPUB0) >= 0)
                 Program.wmi.DeviceSet(ASUSWmi.PPT_CPUB0, limit_cpu, "PowerLimit B");
 
-
-
-
         }
 
 
-        public void AutoFans(bool force = false)
+        public void AutoFans()
         {
 
-            if (force || Program.config.getConfigPerf("auto_apply") == 1)
+            if (Program.config.getConfigPerf("auto_apply") == 1)
             {
                 int cpuResult = Program.wmi.SetFanCurve(0, Program.config.getFanConfig(0));
                 int gpuResult = Program.wmi.SetFanCurve(1, Program.config.getFanConfig(1));
@@ -901,7 +894,7 @@ namespace GHelper
                 if (cpuResult != 1 || gpuResult != 1) // something went wrong, resetting to default profile
                 {
                     int mode = Program.config.getConfig("performance_mode");
-                    Logger.WriteLine("Bios rejected fan curve, resetting mode to " + mode);
+                    Logger.WriteLine("Driver rejected fan curve, resetting mode to " + mode);
                     Program.wmi.DeviceSet(ASUSWmi.PerformanceMode, mode, "PerformanceMode");
                 }
                 else
@@ -912,26 +905,35 @@ namespace GHelper
 
         }
 
-        public void AutoPower(bool force = false)
+        public void AutoPower(int delay = 0)
         {
-            if (force || Program.config.getConfigPerf("auto_apply_power") == 1)
+            if (Program.config.getConfigPerf("auto_apply_power") == 1)
             {
-                var timer = new System.Timers.Timer(1000);
-                timer.Elapsed += delegate
+                if (delay > 0)
+                {
+                    var timer = new System.Timers.Timer(1000);
+                    timer.Elapsed += delegate
+                    {
+                        timer.Stop();
+                        timer.Dispose();
+                        SetPower();
+                    };
+                    timer.Start();
+                } else
                 {
-                    timer.Stop();
-                    timer.Dispose();
                     SetPower();
-                };
-                timer.Start();
+                }
+
             }
 
         }
 
 
-        public void SetPerformanceMode(int PerformanceMode = ASUSWmi.PerformanceBalanced, bool notify = false)
+        public void SetPerformanceMode(int PerformanceMode = -1, bool notify = false)
         {
 
+            if (PerformanceMode < 0)
+                PerformanceMode = Program.config.getConfig("performance_mode");
 
             buttonSilent.Activated = false;
             buttonBalanced.Activated = false;
@@ -973,7 +975,7 @@ namespace GHelper
             }
 
             AutoFans();
-            AutoPower();
+            AutoPower(1000);
 
             if (Program.config.getConfigPerf("auto_boost") != -1)
             {
@@ -1011,10 +1013,10 @@ namespace GHelper
 
             if (SystemInformation.PowerStatus.PowerLineStatus == PowerLineStatus.Online)
                 Aura.ApplyBrightness(3);
-            //Program.wmi.DeviceSet(ASUSWmi.UniversalControl, ASUSWmi.KB_Light_Up);
+                //Program.wmi.DeviceSet(ASUSWmi.UniversalControl, ASUSWmi.KB_Light_Up);
             else
                 Aura.ApplyBrightness(0);
-            //Program.wmi.DeviceSet(ASUSWmi.UniversalControl, ASUSWmi.KB_Light_Down);
+                //Program.wmi.DeviceSet(ASUSWmi.UniversalControl, ASUSWmi.KB_Light_Down);
 
 
         }
@@ -1049,7 +1051,11 @@ namespace GHelper
             var Plugged = SystemInformation.PowerStatus.PowerLineStatus;
 
             bool GpuAuto = Program.config.getConfig("gpu_auto") == 1;
-            if (!GpuAuto) return false;
+            bool ForceGPU = Program.config.ContainsModel("503");
+
+            int GpuMode = Program.config.getConfig("gpu_mode");
+
+            if (!GpuAuto && !ForceGPU) return false;
 
             int eco = Program.wmi.DeviceGet(ASUSWmi.GPUEco);
             int mux = Program.wmi.DeviceGet(ASUSWmi.GPUMux);
@@ -1058,16 +1064,18 @@ namespace GHelper
                 return false;
             else
             {
-                if (eco == 1 && Plugged == PowerLineStatus.Online)  // Eco going Standard on plugged
-                {
-                    SetEcoGPU(0);
-                    return true;
-                }
-                else if (eco == 0 && Plugged != PowerLineStatus.Online)  // Standard going Eco on plugged
-                {
-                    SetEcoGPU(1);
-                    return true;
-                }
+                if (eco == 1)
+                    if ((GpuAuto && Plugged == PowerLineStatus.Online) || (ForceGPU && GpuMode == ASUSWmi.GPUModeStandard))
+                    {
+                        SetEcoGPU(0);
+                        return true;
+                    }
+                if (eco == 0)
+                    if ((GpuAuto && Plugged != PowerLineStatus.Online) || (ForceGPU && GpuMode == ASUSWmi.GPUModeEco))
+                    {
+                        SetEcoGPU(1);
+                        return true;
+                    }
             }
 
             return false;
@@ -1096,8 +1104,8 @@ namespace GHelper
             int eco = Program.wmi.DeviceGet(ASUSWmi.GPUEco);
             int mux = Program.wmi.DeviceGet(ASUSWmi.GPUMux);
 
-            //Logger.WriteLine("Eco flag : " + eco);
-            //Logger.WriteLine("Mux flag : " + mux);
+            Logger.WriteLine("Eco flag : " + eco);
+            Logger.WriteLine("Mux flag : " + mux);
 
             int GpuMode;
 

app/Startup.cs

@@ -22,31 +22,43 @@ public class Startup
 
         var userId = WindowsIdentity.GetCurrent().Name;
 
-        TaskDefinition td = TaskService.Instance.NewTask();
-        td.RegistrationInfo.Description = "GHelper Auto Start";
-        td.Triggers.Add(new LogonTrigger { UserId = userId });
-        td.Actions.Add(strExeFilePath);
-
-        td.Settings.StopIfGoingOnBatteries = false;
-        td.Settings.DisallowStartIfOnBatteries = false;
-        td.Settings.ExecutionTimeLimit = TimeSpan.Zero;
-
-        Debug.WriteLine(strExeFilePath);
-        Debug.WriteLine(userId);
-
-        try
+        using (TaskDefinition td = TaskService.Instance.NewTask())
         {
-            TaskService.Instance.RootFolder.RegisterTaskDefinition(taskName, td);
-        } catch (Exception e)
-        {
-            MessageBox.Show(e.ToString(), "Scheduler Error", MessageBoxButtons.OK);
+            td.RegistrationInfo.Description = "G-Helper Auto Start";
+            td.Triggers.Add(new LogonTrigger { UserId = userId });
+            td.Actions.Add(strExeFilePath);
+
+            td.Settings.StopIfGoingOnBatteries = false;
+            td.Settings.DisallowStartIfOnBatteries = false;
+            td.Settings.ExecutionTimeLimit = TimeSpan.Zero;
+
+            Debug.WriteLine(strExeFilePath);
+            Debug.WriteLine(userId);
+
+            try
+            {
+                TaskService.Instance.RootFolder.RegisterTaskDefinition(taskName, td);
+            }
+            catch (Exception e)
+            {
+                MessageBox.Show("Can't create a start up task. Try running Task Scheduler by hand and manually deleting GHelper task if it exists there.", "Scheduler Error", MessageBoxButtons.OK);
+            }
         }
 
     }
 
     public static void UnSchedule()
     {
-        TaskService taskService = new TaskService();
-        taskService.RootFolder.DeleteTask(taskName);
+        using (TaskService taskService = new TaskService())
+        {
+            try
+            {
+                taskService.RootFolder.DeleteTask(taskName);
+            }
+            catch (Exception e)
+            {
+                MessageBox.Show("Can't remove task. Try running Task Scheduler by hand and manually deleting GHelper task if it exists there.", "Scheduler Error", MessageBoxButtons.OK);
+            }
+        }
     }
 }

docs/README.md

@@ -1,4 +1,3 @@
- 
 # [G-Helper](https://github.com/seerge/g-helper)
 
 [![Github all releases](https://img.shields.io/github/downloads/seerge/g-helper/total.svg)](https://GitHub.com/seerge/g-helper/releases/) [![GitHub release](https://img.shields.io/github/release/seerge/g-helper.svg)](https://GitHub.com/seerge/g-helper/releases/) [![GitHub stars](https://img.shields.io/github/stars/seerge/g-helper.svg?style=social&label=Star)](https://GitHub.com/seerge/g-helper/stargazers/)
@@ -11,15 +10,17 @@ A small utility that allows you to do almost everything you could do with Armour
 ### :gift: Main advantages 
 
 1. Seamless and automatic GPU switching (without asking you to close all apps, etc)
-2. All performance modes can be fully customised (with fan curves and PPTs)
+2. All performance modes can be fully customized (with fan curves and PPTs)
 3. Very lightweight and consumes almost no resources, doesn't install any services. Just a single exe to run
 4. Simple and clean native UI with easy access to all settings
 
+_Doesn't need administrator privileges to run!_
+
 ### [:floppy_disk: Download latest release](https://github.com/seerge/g-helper/releases/latest/download/GHelper.zip)
 
 If you like this app, please [star :star: it on Github](https://github.com/seerge/g-helper) and spread a word about it!
 
-If you post about app - please include a link. Thanks.
+If you post about the app - please include a link. Thanks.
 
 ![Screenshot 2023-03-30 115149](https://user-images.githubusercontent.com/5920850/228799078-bc93148f-6580-4319-b9e6-fbde4d246cd2.png)
 
@@ -30,7 +31,7 @@ If you post about app - please include a link. Thanks.
 3. Laptop screen refresh rate 60hz or 120hz (144hz, etc depending on the model) with display overdrive (OD)
 4. Default and custom fan profiles for every performance mode
 5. Power limits (PPT) for every performance mode
-6. CPU turbo boost mode
+6. CPU turbo boost setting for each mode
 7. Keyboard backlit animation and colors
 8. Anime matrix control thanks to [Starlight](https://github.com/vddCore/Starlight) + some tweaks from my side (including animated GIFs)
 9. FN+F5 cycles performance modes, FN+F4 cycles keyboard animation modes
@@ -38,10 +39,11 @@ If you post about app - please include a link. Thanks.
 11. Battery charge limit to preserve battery health
 12. Monitor CPU / GPU temperature, fan speeds and battery discharge rate
 
-### :gear: Automatic switching of modes when on battery or plugged in
+### :gear: Automatic switching when on battery or plugged in
 - Performance modes (app remembers last mode used on battery or when plugged)
 - Optimized GPU mode - disables dGPU on battery and enables when plugged
 - Auto Screen refresh rate (60hz on battery, 120+ hz when plugged)
+- Keyboard backlight can be turned off on battery
 
 To keep auto switching and hotkeys working the app needs to stay in running in the tray. It doesn't consume any resources. 
 
@@ -77,7 +79,7 @@ Ultimate mode is supported (by hardware) only on G14 2022 (and possibly other mo
 Unfortunately 2020 model doesn't support that on hardware level
 
 ### Should I apply custom PPTs and fan profiles?
-You don't have to, it's purely optional. From my experience built in (in bios) performance modes work well. Limit your power or apply custom fan curves only if you have issues. As sooon as you click Apply in fan + power section bios will be considering fan profile as "custom"! (no matter if you modified it or not)
+You don't have to, it's purely optional. From my experience built in (in bios) performance modes work well. Limit your power or apply custom fan curves only if you have issues. As soon as you click Apply in the fan + power section bios will be considering the fan profile as "custom"! (no matter if you modified it or not)
 
 ### How does G-helper control my fan speeds?
 It doesn't. Your bios does (same as in case with armoury). What G-helper can do - is (optionally) set a custom fan profile to current performance mode consisting of 8 pairs of temperature + fan speed % via same endpoint armoury seem to use.
@@ -95,7 +97,7 @@ Please check system tray for a (G) icon. By default windows is keen to hide all
 Open "Event Viewer" from start menu, go to Windows Logs -> Application and check for recent Errors mentioning G-Helper. If you see one - please post a [new issue](https://github.com/seerge/g-helper/issues) with all details from this error.
 
 ### Can I use MyASUS app along with G-Helper?
-Sure, you can! The only problem is that MyASUS may override battery charge limit that you set before. My advice in such case would be to set same limit (i.e. 80%) in both MyASUS and G-Helper.
+Sure, you can! The only problem is that MyASUS may override the battery charge limit that you set before. My advice in such a situation would be to set the same limit (i.e. 80%) in both MyASUS and G-Helper.
 
 ### How do I uninstall G-helper?
 G-helper is a single exe, and it doesn't install anything in the system. To remove it - you can simply delete exe :) If you have applied any custom fan profiles or PPTs - before removing I would recommend selecting your favorite performance mode (for example balanced) and clicking "Factory defaults" under Fans + Power.
@@ -112,13 +114,13 @@ G-helper is a single exe, and it doesn't install anything in the system. To remo
 
 - Microsoft [.NET7](https://dotnet.microsoft.com/en-us/download). Most probably you already have it. Otherwise you can [download it](https://dotnet.microsoft.com/en-us/download/dotnet/thank-you/sdk-7.0.202-windows-x64-installer) from the official website.
 
-- [Asus System Control Interface](https://dlcdnets.asus.com/pub/ASUS/nb/Image/CustomComponent/ASUSSystemControlInterfaceV3/ASUSSystemControlInterfaceV3.exe). If you have or had MyASUS app installed this "driver" probably still in place (even after MyASUS uninstalls). Alternatively - you can download and install it, and later disable / remove unnecessary services by running [this bat file](https://raw.githubusercontent.com/seerge/g-helper/main/debloat.bat) as admin.
+- [Asus System Control Interface](https://dlcdnets.asus.com/pub/ASUS/nb/Image/CustomComponent/ASUSSystemControlInterfaceV3/ASUSSystemControlInterfaceV3.exe). If you have or had MyASUS app installed this "driver" probably still in place (even after MyASUS uninstalls). Alternatively - you can download and install it
+
+- Optionally(!) you can disable / remove unnecessary services by running [this debloat bat file](https://raw.githubusercontent.com/seerge/g-helper/main/debloat.bat) as admin. To restore services - run [this bloat bat file](https://raw.githubusercontent.com/seerge/g-helper/main/bloat.bat) instead.
 
 - I recommend keeping "Asus Optimization Service" running, as it keeps basic laptop hotkeys such as screen or keyboard brightness adjustment working.
 
-- It's not recommended to use an app in combination with Armoury Crate services, cause they adjust the same settings. You can [uninstall it using it's own uninstall tool](https://dlcdnets.asus.com/pub/ASUS/mb/14Utilities/Armoury_Crate_Uninstall_Tool.zip?model=armoury%20crate). Just in case, you can always install it back later.
-
-Note: Doesn't need administrator privileges to run!
+- It's not recommended to use an app in combination with Armoury Crate services, because they adjust the same settings. You can [uninstall it using it's own uninstall tool](https://dlcdnets.asus.com/pub/ASUS/mb/14Utilities/Armoury_Crate_Uninstall_Tool.zip?model=armoury%20crate). Just in case, you can always install it back later.
 
 -------------------------------